search

gwu-libraries / inventory_old

A system for tracking location of digital items and progress in reformatting projects
MIT License
5 stars 1 forks source link

Added new bag action and 2 columns for the Bag model. Fixes #223 #229

Open darshanrp opened 10 years ago

dchud commented 10 years ago

I see that this successfully adds the columns to the model. Is this sufficient for this ticket, or do we need to proceed to change the way inventory handles bag deletions, and the UI to reflect these changes, as part of this ticket?

If not, we need one or two more tickets. :)

darshanrp commented 10 years ago

@dchud The UI changes are in, but to test this I had to manually set a bag 'is_deleted=true' as clint needs to be fixed for these new changes. Also, the query for child bags is not yet done. If you think those changes should go into a separate ticket, then this PR is ready to be merged.

darshanrp commented 10 years ago

@dchud If we merge this in and push this release, it might break clint in its current state.

darshanrp commented 10 years ago

@dchud I tested clint with Inventory after these model changes, I can't reproduce that error which I had got after the model changes. This pull request can be merged without any changes to clint

darshanrp commented 10 years ago

merge https://github.com/gwu-libraries/inventory/pull/238 before merging this pull request into master