search

gwu-libraries / lai-libsite

ARCHIVED. Code merged into new library.gwu.edu repo, and tickets transferred there. Old description: Drupal 7 theme for GW Libraries. Based on earlier Libsite7 theme.
MIT License
2 stars 0 forks source link

Add GA search dropdown code to repo #133

Closed maxstarkenburg closed 6 years ago

maxstarkenburg commented 6 years ago

The recently pushed Google Analytics code for click events on the search dropdowns needs to be added to this repository. From what I gleaned while looking at the diff, it seems there were a few issues. One dealing w/ carriage returns being added to every line. Another being I don't understand the decision to recreate the button/image instead of just changing the attributes that need to get changed, so as to reduce code duplication (and in this process things happening like attributes getting added that don't make sense, e.g. alt on <input>).

maxstarkenburg commented 6 years ago

I'm going to close this issue anyway, since the search bars are likely to be implemented completely differently for Primo integration.