gwu-libraries / lai-libsite

ARCHIVED. Code merged into new library.gwu.edu repo, and tickets transferred there. Old description: Drupal 7 theme for GW Libraries. Based on earlier Libsite7 theme.
MIT License
2 stars 0 forks source link

implement new primo-style search box #140

Closed maxstarkenburg closed 6 years ago

maxstarkenburg commented 6 years ago

See this branch for reference (though it contains really junky code done for quickly mocking up for user testing purposes).

maxstarkenburg commented 6 years ago

Still need to do before sending pull request for review:

maxstarkenburg commented 6 years ago

@rdelaloy and @qbaron: Seeking your input on the blue navbar menu dropdown under Research. Currently the links (at least for Gelman) in the first section look like:

~~Find Books & Media Journals | Tutorial Subject Databases | Tutorial ArticlesPlus | Tutorial Classic Catalog GW ScholarSpace~~

Classic Catalog is easily enough; we'll just remove that line. Should "Books & Media" be replaced with "Catalog" and point to an empty catalog-scoped Primo search? Should "Journals" point to https://wrlc-gwu.primo.exlibrisgroup.com/discovery/jsearch?vid=01WRLC_GWA:live? Should "ArticlesPlus" be changed to "Articles" and point to an empty articles-scoped Primo search?

See #142 for menu change decisions.

Presumably things like those HowDoI/Tutorials will need to be updated. And we can use the "Search and Replace Scanner" to find some of the other content that needs updating, but I don't think that tool searches blocks or sidebar menus. I noticed, for example, there's a link on a page like https://library.gwu.edu/search/node?keys=blah to "All Search" (Bento) that's in a block.~~

maxstarkenburg commented 6 years ago

Code bug found: To reproduce:

Seems to happen on all of FF, Chrome and Safari on Mac. On both homepage and non-homepages.

Note to self: Be careful not to break things for the case where nothing was typed into the search box (where hitting Enter while focused on of the right-hand dropdown options throws your focus back into the empty search box).

maxstarkenburg commented 6 years ago

Except for the aria attributes and perhaps other accessibility-related improvements that we're not so sure about, this is now done.