search

gwu-libraries / lai-libsite

ARCHIVED. Code merged into new library.gwu.edu repo, and tickets transferred there. Old description: Drupal 7 theme for GW Libraries. Based on earlier Libsite7 theme.
MIT License
2 stars 0 forks source link

Updated Eckles menu ... #164

Closed maxstarkenburg closed 5 years ago

maxstarkenburg commented 5 years ago

... with changes as requested in #158. Tested by self in desktop, phone, and iPad, since the menus behave a little differently in all those contexts (width differences and touch vs. non-touch differences).

maxstarkenburg commented 5 years ago

Not quite sure why those pages are erroring. They seem to exist in /admin/content, for example, though when I visit them, it looks like the dblog is producing errors that look like: ParseError: syntax error, unexpected '??' (T_COALESCE), expecting end of file in php_eval() (line 2 of /home/library/www/html/modules/php/php.module(80) : eval()'d code).

retrospec commented 5 years ago

@maxstarkenburg Twitter blocks using PHP filter format (Gelman Twitter @GelmanLibrary [block ID 36], Gelman Twitter @GWUArchives [block ID 59]) contained improperly closed PHP tags (i.e. ??>).

Pages using block are accessible and syntax error no longer shows up post-correction.

Here's the reference to the null coalescing operator add in PHP 7. This explains why nodes using block are still readable on Library prod and your dev instances.