search

gwu-libraries / lai-libsite

ARCHIVED. Code merged into new library.gwu.edu repo, and tickets transferred there. Old description: Drupal 7 theme for GW Libraries. Based on earlier Libsite7 theme.
MIT License
2 stars 0 forks source link

Remove reports.library references in Virginia menus and replace them with ... ? #171

Closed maxstarkenburg closed 5 years ago

maxstarkenburg commented 5 years ago

The VSTC blue nav menu on libsite still has links to reports.library.gwu.edu (go to https://library.gwu.edu/virginia and hover "Collections", and you'll find the "New Books" and "The Virginia Collection" go to pages on reports). I believe from https://servicedesk.wrlc.org/SelfService/Display.html?id=17288 this was supposed to be decommissioned a while ago, but doesn't seem to actually have been taken down.

But I don't know what the replacement should be in the menu (currently hardcoded via the theme). The remaining item under "Collections" ("Grants & Foundations") goes to a page that doesn't even seem to be about collections, so should we remove that item entirely and put "Grants & Foundations" elsewhere (perhaps somewhere under "Library Services")? I'm hesitant to make it its own top-level thing just for space issues.

maxstarkenburg commented 5 years ago

I guess perhaps it's also good the gwreports server wasn't taken down because, coincidentally just today, I was directed to http://reports.library.gwu.edu/libstats/questionAddForm.do to add information regarding my consultation appointment.

rdelaloy commented 5 years ago

@qbaron can you work with Max and Tara to figure out this menu. @maxstarkenburg that "grants & foundations" thing used to be a signature program for VSTC Library, but I'm not sure how big a deal it is anymore. I don't think they offer training on it anymore.

qbaron commented 5 years ago

Per Tara, we'll remove "New Books" and "The Virginia Collection" from Collections. "Grants & Foundations" should move from Collections to the bottom of Library Services. Collections should be removed from the top menu.

Additionally, "Nursing Books at VSTCL" (https://wrlc-gwu.primo.exlibrisgroup.com/discovery/search?query=any,contains,nursing&tab=WRLC&search_scope=DiscoveryNetwork&sortby=date_d&vid=01WRLC_GWA:live&facet=library,include,4107%E2%80%93775147160004107&offset=0&came_from=sort) should be added to the Research menu, last under the "FIND" heading

maxstarkenburg commented 5 years ago

@qbaron, I've made a commit with the above changes as requested. I put the Grants & Foundations line as last under Library Services, but dunno if it should have been higher up? Noting that in smaller screens, there are now only 5 menu buttons on Virginia page, but maybe that's fine (and maybe my last comment in #161 could mean there might soon only be 4 anyway?).

qbaron commented 5 years ago

Where can I see these changes? Your dev site?

maxstarkenburg commented 5 years ago

Where can I see these changes? Your dev site?

@qbaron: I've been switching my dev back and forth between using master branch and using these tickets' branches, so it may not always be there, but lemme try to make a different branch that combines them all so that you can see all my recent changes in action.

Update: ok, my recent work for #161, #171, and #172 should all be on dev1-library dot wrlc dot org at the moment.

qbaron commented 5 years ago

@maxstarkenburg – I think this is good. Thanks for pointing out the issue with the "Events" menu item. As you suggested, let's remove that from the menu and place the sub items under "About"

About Hours Events Map & Directions Access Staff Positions Available Libraries & Academic Innovation Vision Magazine Contact Us

I'm okay with bringing the mobile items down to 4

maxstarkenburg commented 5 years ago

Should we even have Events under About for Virginia? Besides the fact that most LAI events are at Gelman (and there's not an existing filter for location), I guess it feels a bit odd to me to break up links that mostly start with /virginia/... with one that's doesn't (/events).

qbaron commented 5 years ago

I didn't realize how many of those are Virginia specific.

/virginia/jobs shouldn't exist. "Positions Available" should be removed or link to /about/organization/jobs.

I'll let @rdelaloy decide if she's okay with removing "Events" from that menu. (fwiw - Eckles doesn't have "Events" in its menu)

maxstarkenburg commented 5 years ago

Robin let me know in our one-on-one that VSTC didn't need a link to /events, so I've committed that, but to the other ticket's branch #161, since that was the ticket originally about getting rid of News & Events menus. Otherwise, I think this ticket is done, and has thus been pull-requested.

rdelaloy commented 5 years ago

There hasn't been an event at VSTC since I started at Gelman so we're good to remove that from the menu.

ok-steve commented 5 years ago

Fixed: gwu-libraries/library.gwu.edu#6