Fix events display - Githubissues

gwu-libraries / lai-libsite

ARCHIVED. Code merged into new library.gwu.edu repo, and tickets transferred there. Old description: Drupal 7 theme for GW Libraries. Based on earlier Libsite7 theme.

MIT License

2 stars 0 forks source link

Fix events display #172

Closed qbaron closed 5 years ago

qbaron commented 5 years ago

Difference in Chrome/FF on Mac in how the details of the event appear:

https://library.gwu.edu/news-events/events/beyond-brexit

Screen Shot 2019-02-27 at 4 01 59 PM

https://library.gwu.edu/news-events/events/okinawa-essay-contest-presentation

https://library.gwu.edu/news-events/events/bog-plants-and-aquatic-gardens

maxstarkenburg commented 5 years ago

@qbaron, can you check these pages as currently on dev1-library dot wrlc dot org? I can reproduce, on Win browsers, the issues with the Sponsors lines, but not the ones where Event Location was wacky.

qbaron commented 5 years ago

I'm still seeing the same issue

dev1-library.wrlc.org/news-events/events/national-churchill-library-and-center-graduate-research-fellowships

So it's not even FF. It's just a Mac FF issue?

maxstarkenburg commented 5 years ago

Went to the Mac lab to debug (indeed, it was just showing up on Mac for me) but the now committed line-height adjustment was confirmed to work by Quinn as well (seems some combo of the italic font with the "for who knows what reason" existing line-height adjustment was causing just enough height difference to bump things around in Mac).

maxstarkenburg commented 5 years ago

This got closed based on premature merge to master (still hasn't gone through regression testing). Merge since reverted, but ticket close from first merge doesn't get automatically re-opened.

ok-steve commented 5 years ago

Fixed: gwu-libraries/library.gwu.edu#7