Check if nid is in the GET request

gwu-libraries / lai-libsite

ARCHIVED. Code merged into new library.gwu.edu repo, and tickets transferred there. Old description: Drupal 7 theme for GW Libraries. Based on earlier Libsite7 theme.

MIT License

2 stars 0 forks source link

Check if nid is in the GET request #174

Closed ok-steve closed 5 years ago

ok-steve commented 5 years ago

This should fix the dblog error. It just checks whether the GET request has an 'nid' key and sets the $nid variable to NULL. It's a similar problem to all the dblog issues that were in the modules

Fixes #173

maxstarkenburg commented 5 years ago

Maybe scope creep, but I noticed that visiting an individual event page (e.g. /news-events/events/getting-started-blackboard-45-minutes-24) also gives me a single dblog line: Notice: Only variables should be passed by reference in include() (line 116 of /path/to/drupal/build/sites/all/themes/libsite7b/templates/node--events.tpl.php) though I don't see some include() function on line 116 myself, so I clearly don't understend the issue.

ok-steve commented 5 years ago

I've updated the theme to fix the additional error.

maxstarkenburg commented 5 years ago

Looks good on both my dev and Will's VM. Thanks!

Shantay, you stay. :cake:

Haven't tested on a php5 VM like prod, so I'm assuming this should be merged to master at the time that we're ready to make the Ubuntu 18 cut-over.