search

gwu-libraries / launchpad

A django based system that provides a stable URL for every item in the library's catalog. Various discovery services will link to these URLs. The page for each item will in turn link out to various other resources that provide methods for accessing the content of the items.
MIT License
15 stars 9 forks source link

Error with DDA link logic #1208

Closed lwrubel closed 6 years ago

lwrubel commented 6 years ago

Getting this error occasionally. Can be reproduced by going to:

https://findit.library.gwu.edu/item/17586932 

unable to render bibid: 17586932
Traceback (most recent call last):
  File "/launchpad/current/launchpad/lp/ui/views.py", line 72, in item
    holdings = voyager.get_holdings(bib)
  File "/launchpad/current/launchpad/lp/ui/voyager.py", line 661, in get_holdings
    holding['ONLINE'] = get_links(holding, dda_isbn, dda_title)
  File "/launchpad/current/launchpad/lp/ui/voyager.py", line 1828, in get_links
    '/?title=' + title + '&isbn=' + isbn
TypeError: cannot concatenate 'str' and 'NoneType' objects

Request repr(): unavailable
lwrubel commented 6 years ago

Closed by #1215.