search

gwu-libraries / launchpad

A django based system that provides a stable URL for every item in the library's catalog. Various discovery services will link to these URLs. The page for each item will in turn link out to various other resources that provide methods for accessing the content of the items.
MIT License
15 stars 9 forks source link

shorten ILLiad/OCLC source ID field #340

Closed cummingsm closed 11 years ago

cummingsm commented 11 years ago

(per Laura): Glenn discovered and confirmed with OCLC that ILLiad limits the source ID field to 40 characters. Since many OpenURLs have long source IDs (e.g. EBSCO:Communication & Mass Media Index), not only does the source ID gets truncated in ILLiad, but "GWLaunchpad" never makes it into ILLiad.

This gets in the way of collecting statistics and tracking user paths through our interfaces.

Here is one way to approach the problem: 1) Start using a shorter yet still unique code for GWLaunchpad. How about GWLP? and 2) Have Launchpad truncate the source ID it receives to 35 characters before appending ":GWLP"

Thanks for considering this. There may be other ways to handle this as well.

razagilani commented 11 years ago

fixes #340

razagilani commented 11 years ago

It is fixed as a result of merging code_cleanup into master. The ticket didn't close as the commit comment used closed instead of fixes.

cummingsm commented 11 years ago

This issue and #347 are related. The ILL form contains html encoding in the fields.

razagilani commented 11 years ago

Should this be closed now the that the encoding problem is fixed?

cummingsm commented 11 years ago

Yes, you changed the code to compensate for the ampersand character within the name of the data sources. I believe this issue is ready to close.

On Tue, Aug 20, 2013 at 12:51 PM, Raza Gilani notifications@github.comwrote:

Shoul this be closed now the that the encoding problem is fixed?

— Reply to this email directly or view it on GitHubhttps://github.com/gwu-libraries/launchpad/issues/340#issuecomment-22959566 .

razagilani commented 11 years ago

Yes that change has been already made. On Aug 20, 2013 1:43 PM, "Michael Cummings" notifications@github.com wrote:

Yes, you changed the code to compensate for the ampersand character within the name of the data sources. I believe this issue is ready to close.

On Tue, Aug 20, 2013 at 12:51 PM, Raza Gilani notifications@github.comwrote:

Shoul this be closed now the that the encoding problem is fixed?

— Reply to this email directly or view it on GitHub< https://github.com/gwu-libraries/launchpad/issues/340#issuecomment-22959566>

.

— Reply to this email directly or view it on GitHubhttps://github.com/gwu-libraries/launchpad/issues/340#issuecomment-22962526 .

razagilani commented 11 years ago

Just verified that ILLIAD_URL has been changed from http to https on master. closing this.