search

gwu-libraries / scholarspace

GWU's Sufia-based repository app for preservation and open access to scholarly output of the GWU community
MIT License
0 stars 0 forks source link

Set Shibboleth as optional config #233

Closed kilahimm closed 8 years ago

kilahimm commented 8 years ago

resolves #229

kerchner commented 8 years ago

@kilahimm This looks good except you may want to move this block

# Method added by Blacklight; Blacklight uses #to_s on your
# user class to get a user-displayable login/identifier for
# the account.
def to_s
  email
end

outside the if/else/end structure, rather than repeating it twice.

kilahimm commented 8 years ago

@kerchner I've updated the PR per your recommendation.