search

gwu-libraries / sfm-ui

Social Feed Manager user interface application.
http://gwu-libraries.github.io/sfm-ui
MIT License
153 stars 25 forks source link

Twitter v2 search UI field changes #1115

Closed kerchner closed 2 years ago

kerchner commented 2 years ago

Create a branch off of twitter_v2 branch:

On the Twitter v2 search seed form, remove Start time and End time.

On the Twitter v2 academic search seed form, add warning to encourage use of start and end times in order to help avoid using up monthly limit imposed by the API. Provide link to https://developer.twitter.com/en/docs/twitter-api/getting-started/about-twitter-api#v2-access-level

adhithyakiran commented 2 years ago

completed the changes and is pushed in the branch twv2-ui-datefields

dolsysmith commented 2 years ago

Hi @adhithyakiran,

Thanks for your work on this. It looks good -- I have just a few minor suggestions.

  1. The Bootstrap alerts are color-coded; warnings are supposed to be yellow, but your box is showing up as green, which is code for "success." I think we want to stick to convention and make the warning box use the warning color.
  2. If you change the color, I don't think you need to include the text Warning! in the box itself.
  3. There's a space missing after the period in the first sentence.
  4. Can we move the warning below the query box and above the date selectors? That would seem the more logical place for it. And maybe the warning could mention using either start/end times or a limit (since both are potentially good options for sizing the harvest, depending on the use case).
adhithyakiran commented 2 years ago

Changes are done!

adhithyakiran commented 2 years ago

image