search

gwu-libraries / sfm-ui

Social Feed Manager user interface application.
http://gwu-libraries.github.io/sfm-ui
MIT License
153 stars 25 forks source link

Twv2 UI datefields #1122

Closed adhithyakiran closed 2 years ago

adhithyakiran commented 2 years ago

Date fields restored for twitter search version2 Added warning message for twitter academic search seed

dolsysmith commented 2 years ago

@adhithyakiran I am getting an error message when trying to add an Academic Search seed:

Screen Shot 2022-08-11 at 9 00 39 AM

It seems to be looking for a file that doesn't exist?

dolsysmith commented 2 years ago

@adhithyakiran It looks good, but can you add a space after the period and before See Twitter in the alert, and also before Limits are approximate in the help text?

Once you do that, I think you can squash and merge this PR. (We usually do squash and merge so that the commit history doesn't get too big.)

dolsysmith commented 2 years ago

Hi @adhithyakiran, I tested your changes to the credentials form. Unfortunately, by changing the Python name of the form in forms.py, it breaks references to this element elsewhere in the code:

  File "/opt/sfm-utils/sfmutils/harvester.py", line 239, in on_message
    self.harvest_seeds()
  File "twitter_harvester.py", line 48, in harvest_seeds
    self._create_twarc2()
  File "twitter_harvester.py", line 81, in _create_twarc2
    self.twarc = Twarc2(self.message["credentials"]["consumer_key"],
KeyError: 'consumer_key'

Can you try instead keeping the element names as they were but adding a label attribute? See here for some examples that might work.