search

gwu-libraries / sfm-ui

Social Feed Manager user interface application.
http://gwu-libraries.github.io/sfm-ui
MIT License
153 stars 25 forks source link

CSV/Excel export has blank text field #935

Closed justinlittman closed 6 years ago

justinlittman commented 6 years ago

See, for example, https://sfm.library.gwu.edu/ui/exports/563/

The problem is because clean_str() in json2csv.py checks if a string is a str, which works for python 3. However, for python 2, should check if unicode.

Until this fix, work around is to export to JSON and manually run utils/json2csv.py with python 3.

justinlittman commented 6 years ago

PR submitted https://github.com/DocNow/twarc/pull/230 with fix.

justinlittman commented 6 years ago

Fixed by https://github.com/gwu-libraries/sfm-twitter-harvester/commit/6930118c24c3c0767547b596eb17dfb3f89385cb