gwynethguo / pe

0 stars 0 forks source link

Special Character in Discharge Date #10

Open gwynethguo opened 1 year ago

gwynethguo commented 1 year ago

The date time format allows the following input: edit 4 d/27/07/2023 1600�

image.png

Which should not be allowed. The result in the patient card also has the special character for the discharge date inside.

nus-pe-bot commented 1 year ago

Team's Response

While it does allow inputting special characters, it only allows them to be added to the time segment of the date-time. As such, it does not affect normal operations such as sort. Also, this is not behavior that would affect many users.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: I think this bug should be labeled as severity.Medium or severity.High as it allows invalid dates to be inputted into the date format.

The user can also input invalid characters instead of the special characters. This means that the application allows a command format that is different than the format that should be followed in the User Guide.

image.png

Restrictions should be strict. This can prevent the user from obvious misinputs (e.g. the user misinputs the time to be 16001, and the application detects that there is a date time format error), which is one of the important features in a CLI application.

Therefore, the bug should be labeled as severity.Medium or severity.High.