search

gwynethguo / pe

0 stars 0 forks source link

Delete Command: Confirmation Box #6

Open gwynethguo opened 1 year ago

gwynethguo commented 1 year ago

In my opinion, the invalid command format output for deleting a patient should be displayed before the confirmation box is shown. This could be done by checking the command format for errors first, then showing the confirmation box after.

image.png

image.png

nus-pe-bot commented 1 year ago

Team's Response

We planned for the confirmation window to pop up before checking the command validity. This behaviour is also mentioned in our User Guide:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I think it doesn't really make sense to pop up a confirmation box first before actually detecting whether there is a command format error. When executing the wrong command format, I thought that my command is correct and I expect something to be deleted after the confirmation window.

Maybe this implementation can be considered in the future versions, so it is maybe possible to include this bug as a response.NotInScope bug.