search

gxquickly / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Clean up TIntermTraverser #1037

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Default parameters in the TIntermTraverser constructor can make subclass 
behavior somewhat unclear. There's a TODO in the code to get rid of them.

Right-to-left traversal is not used anywhere, so it could be removed as well to 
simplify the code.

Original issue reported on code.google.com by oetu...@nvidia.com on 3 Jun 2015 at 2:56

GoogleCodeExporter commented 9 years ago

Original comment by oetu...@nvidia.com on 3 Jun 2015 at 2:56

GoogleCodeExporter commented 9 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/64f0be91d2856ecd07ddfe53dd76df115e23b906

commit 64f0be91d2856ecd07ddfe53dd76df115e23b906
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Wed Jun 03 14:38:34 2015

Remove unused right-to-left AST traversal support

No code actually uses the right-to-left traversal. All it does is add
unnecessary complexity.

TEST=angle_unittests, angle_end2end_tests
BUG=angleproject:1037

Change-Id: Id15498343538c02c252ef0852f9a00c85ac3c4bb
Reviewed-on: https://chromium-review.googlesource.com/275183
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

[modify] 
http://crrev.com/64f0be91d2856ecd07ddfe53dd76df115e23b906/src/compiler/translato
r/IntermTraverse.cpp
[modify] 
http://crrev.com/64f0be91d2856ecd07ddfe53dd76df115e23b906/src/compiler/translato
r/RewriteElseBlocks.cpp
[modify] 
http://crrev.com/64f0be91d2856ecd07ddfe53dd76df115e23b906/src/compiler/translato
r/IntermNode.h

Original comment by bugdroid1@chromium.org on 8 Jun 2015 at 7:44

GoogleCodeExporter commented 9 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3d0d9a483ebb6e894f1d1049c5587ced2786e986

commit 3d0d9a483ebb6e894f1d1049c5587ced2786e986
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Mon Jun 01 09:16:36 2015

Clean up TIntermTraverser usage

Remove default parameters from TIntermTraverser.

Also clean up a few dead function declarations in traversers.

TEST=angle_unittests, angle_end2end_tests
BUG=angleproject:1037

Change-Id: I8d126c6c2d5b53e8b14e23e3d102f204a59323b3
Reviewed-on: https://chromium-review.googlesource.com/275184
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/ForLoopUnroll.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/VersionGLSL.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/FlagStd140Structs.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/ValidateOutputs.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/BuiltInFunctionEmulator.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/ScalarizeVecAndMatConstructorArgs.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/UnfoldShortCircuitAST.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/VariableInfo.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/tests/compiler_tes
ts/ConstantFolding_test.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/IntermNode.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/RegenerateStructNames.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/InitializeVariables.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/third_party/compil
er/ArrayBoundsClamper.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/TranslatorGLSL.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/UnfoldShortCircuitToIf.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/SeparateExpressionsReturningArrays.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/parseConst.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/intermOut.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/NodeSearch.h
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/ValidateLimitations.cpp
[modify] 
http://crrev.com/3d0d9a483ebb6e894f1d1049c5587ced2786e986/src/compiler/translato
r/SearchSymbol.cpp

Original comment by bugdroid1@chromium.org on 8 Jun 2015 at 8:28

GoogleCodeExporter commented 9 years ago

Original comment by oetu...@nvidia.com on 8 Jun 2015 at 9:04