search

gxquickly / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Return std::string type instead of char* in ShaderLang APIs #816

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
So a caller doesn't have to query the max size of the string first, and then 
supply a buffer of enough size for the content.

In the history, we suffered from mysterious crashes in chrome because a misuse 
of such two-spec APIs.

The original reason to do C style APIs is no longer there.  We already have C++ 
features in the ShaderLang (std::vector, etc).

So it's time to simply the API and rid of potential memory corruption.

Original issue reported on code.google.com by zmo@chromium.org on 29 Oct 2014 at 10:31

GoogleCodeExporter commented 9 years ago 
Mo, is this fixed now?

Original comment by jmad...@chromium.org on 24 Nov 2014 at 6:05

GoogleCodeExporter commented 9 years ago

Original comment by z...@google.com on 24 Nov 2014 at 6:20