search

gxquickly / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

RemoveAllTreeNodes does nothing and should be removed #831

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
All IntermNodes get allocated using the TPoolAllocator. Their delete() operator 
is empty, as well as their destructors, and don't free any memory. Therefore, 
it is a waste of cycles to call RemoveAllTreeNodes on the interm tree, which 
will not delete all nodes that have been allocated either way (replaceChildNode 
does not delete the replaced node, for example).

RemoveTree.h / RemoveTree.cpp plus related code in the IntermNodes should be 
removed from the code to simplify it.

Original issue reported on code.google.com by oetu...@nvidia.com on 19 Nov 2014 at 10:49

GoogleCodeExporter commented 9 years ago 
Patch in review: https://chromium-review.googlesource.com/230730

Original comment by oetu...@nvidia.com on 19 Nov 2014 at 12:30

GoogleCodeExporter commented 9 years ago 
Patch has landed in Chromium.

Original comment by oetu...@nvidia.com on 11 Dec 2014 at 1:25