search

gxquickly / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Vertex attributes implementation for the GL back-end #880

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Implement the VertexArrayGL class and syncing of vertex attributes for draw 
calls.

Original issue reported on code.google.com by geofflang@chromium.org on 22 Jan 2015 at 6:45

GoogleCodeExporter commented 9 years ago

Original comment by geofflang@chromium.org on 23 Feb 2015 at 9:40

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : 1f40291c8f8b63494dc37f41d82552b495083a52

Code-Review  0 : Geoff Lang
Code-Review  +2: Jamie Madill
Verified     0 : Jamie Madill
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : If3efa26a7fa89306d783c3e8a5fb92b16861d77a
Reviewed-at    : https://chromium-review.googlesource.com/257670

Remove the non-templated RefCountObjectBindingPointer class.

This allows the regular BindingPointer class to template on const types.

Also added assignment and copy operators that don't leak the resources.

BUG=angleproject:880

src/libANGLE/RefCountObject.cpp
src/libANGLE/RefCountObject.h

Original comment by bugdroid1@chromium.org on 17 Mar 2015 at 4:34

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : 6ae6efcae0842409a22906f57a14fbd59a986cf7

Code-Review  0 : Brandon Jones, Geoff Lang, Kenneth Russell
Code-Review  +2: Jamie Madill
Verified     0 : Brandon Jones, Jamie Madill, Kenneth Russell
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : Ifd59c0f67aeab0e4700b3dca57c1b75e3fae48b8
Reviewed-at    : https://chromium-review.googlesource.com/257671

Only sync the VAO state just before the draw call.

BUG=angleproject:880

src/libANGLE/VertexAttribute.cpp
src/libANGLE/VertexAttribute.h
src/libANGLE/renderer/gl/StateManagerGL.cpp
src/libANGLE/renderer/gl/VertexArrayGL.cpp
src/libANGLE/renderer/gl/VertexArrayGL.h

Original comment by bugdroid1@chromium.org on 20 Mar 2015 at 4:41

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : 7c82bc461897f41983d594c827ca7a02149638b3

Code-Review  0 : Brandon Jones, Geoff Lang, Kenneth Russell
Code-Review  +2: Jamie Madill
Verified     0 : Brandon Jones, Jamie Madill, Kenneth Russell
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I67839d4934767db77cff7b501002c5aafbcbaef2
Reviewed-at    : https://chromium-review.googlesource.com/257672

Handle client data for draw calls with RendererGL.

BUG=angleproject:880

src/libANGLE/renderer/gl/RendererGL.cpp
src/libANGLE/renderer/gl/StateManagerGL.cpp
src/libANGLE/renderer/gl/StateManagerGL.h
src/libANGLE/renderer/gl/VertexArrayGL.cpp
src/libANGLE/renderer/gl/VertexArrayGL.h

Original comment by bugdroid1@chromium.org on 23 Mar 2015 at 7:50

GoogleCodeExporter commented 9 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/851cd580d1a74ce44cc22ac1154f4ca3b8d79c35

commit 851cd580d1a74ce44cc22ac1154f4ca3b8d79c35
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue May 26 20:47:23 2015

Check for null attribute buffers before binding.

Fixes:
 * Crash in conformance/extensions/oes-vertex-array-object.html

BUG=angleproject:880

Change-Id: I90eba9b26b2834644ce3ba0e78cab3417c2a7bd1
Reviewed-on: https://chromium-review.googlesource.com/273325
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] 
http://crrev.com/851cd580d1a74ce44cc22ac1154f4ca3b8d79c35/src/libANGLE/renderer/
gl/VertexArrayGL.cpp

Original comment by bugdroid1@chromium.org on 27 May 2015 at 1:17