Texture objects for the GL back-end

GoogleCodeExporter commented 9 years ago

Implement the TextureGL class.

Original issue reported on code.google.com by geofflang@chromium.org on 22 Jan 2015 at 6:49

GoogleCodeExporter commented 9 years ago

Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : c05f7065c90fda86bce7c07d2d1aa3434c239163

Code-Review  0 : Brandon Jones, Kenneth Russell
Code-Review  +2: Geoff Lang
Verified     0 : Brandon Jones, Kenneth Russell
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I877c0a9f753dacff96bbb82486bee71d1996ecb7
Reviewed-at    : https://chromium-review.googlesource.com/252982

TextureGL implementation.

BUG=angleproject:884

src/libANGLE/renderer/gl/RendererGL.cpp
src/libANGLE/renderer/gl/StateManagerGL.cpp
src/libANGLE/renderer/gl/StateManagerGL.h
src/libANGLE/renderer/gl/TextureGL.cpp
src/libANGLE/renderer/gl/TextureGL.h
src/libANGLE/renderer/gl/renderergl_utils.cpp

Original comment by bugdroid1@chromium.org on 17 Mar 2015 at 3:31

GoogleCodeExporter commented 9 years ago

Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : fb2a559726e4bb61814d081070d391fc9203c56e

Code-Review  0 : Geoff Lang
Code-Review  +2: Jamie Madill
Verified     0 : Jamie Madill
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I3406eec99609b85c407797c50b71611b445a6ca5
Reviewed-at    : https://chromium-review.googlesource.com/261462

Fix incorrect assertion.

BUG=angleproject:884

src/libANGLE/renderer/gl/TextureGL.cpp

Original comment by bugdroid1@chromium.org on 20 Mar 2015 at 3:39

GoogleCodeExporter commented 9 years ago

Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : 1c0ad625f6f23008895bbf846babe0376b4c4977

Code-Review  0 : Geoff Lang
Code-Review  +1: Brandon Jones
Code-Review  +2: Kenneth Russell
Verified     0 : Brandon Jones, Kenneth Russell
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : Ie6e809477253502d88f599172eaed17638e58dd3
Reviewed-at    : https://chromium-review.googlesource.com/262112

Emulate TextureStorage when it is not available.

BUG=angleproject:884

src/libANGLE/renderer/gl/TextureGL.cpp

Original comment by bugdroid1@chromium.org on 25 Mar 2015 at 1:53

GoogleCodeExporter commented 9 years ago

Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : 6d5463bda12f1cfb844acd1fc335aabb3c1cf96c

Code-Review  0 : Geoff Lang
Code-Review  +2: Jamie Madill
Verified     0 : Jamie Madill
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I591f493099397bb07608096cf30ff46ed5090224
Reviewed-at    : https://chromium-review.googlesource.com/263147

Always sync the texture sampler state.

The sampler state may have changed even if the texture is already bound.

BUG=angleproject:884

src/libANGLE/renderer/gl/StateManagerGL.cpp

Original comment by bugdroid1@chromium.org on 31 Mar 2015 at 3:19

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49

commit aa3a5fadebb2bad0be07eb2963a9d23f901c4c49
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed May 20 18:10:46 2015

Add table entries for almost all the remaining GL texture formats.

BUG=angleproject:884
BUG=angleproject:967

Change-Id: I0b05841272f4410c33ee4e4c3654846f07b7c39b
Reviewed-on: https://chromium-review.googlesource.com/270275
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Fra
mebufferFormatsTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Ind
exedPointsTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/libANGLE/renderer/
gl/FunctionsGL.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/libANGLE/renderer/
gl/FunctionsGL.h
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Lin
eLoopTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/libANGLE/renderer/
gl/formatutilsgl.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/libANGLE/renderer/
gl/formatutilsgl.h
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Inc
ompleteTextureTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Dep
thStencilFormatsTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Tex
tureTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/libANGLE/renderer/
gl/renderergl_utils.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Swi
zzleTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Cub
eMapTextureTest.cpp
[modify] 
http://crrev.com/aa3a5fadebb2bad0be07eb2963a9d23f901c4c49/src/tests/gl_tests/Ble
ndMinMaxTest.cpp

Original comment by bugdroid1@chromium.org on 25 May 2015 at 2:51

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/f34d1db99a66e8f9e45c1fb90313b6b2084da74c

commit f34d1db99a66e8f9e45c1fb90313b6b2084da74c
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed May 20 18:10:46 2015

Add table entries for almost all the remaining GL texture formats.

BUG=angleproject:884
BUG=angleproject:967

Change-Id: I113757dd9e1fae8fe0241a7286be979a90891b53
Reviewed-on: https://chromium-review.googlesource.com/270275
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/273135

[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Fra
mebufferFormatsTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Ind
exedPointsTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/libANGLE/renderer/
gl/FunctionsGL.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/libANGLE/renderer/
gl/FunctionsGL.h
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Lin
eLoopTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/libANGLE/renderer/
gl/formatutilsgl.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/libANGLE/renderer/
gl/formatutilsgl.h
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Inc
ompleteTextureTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Dep
thStencilFormatsTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Tex
tureTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/libANGLE/renderer/
gl/renderergl_utils.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Swi
zzleTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Cub
eMapTextureTest.cpp
[modify] 
http://crrev.com/f34d1db99a66e8f9e45c1fb90313b6b2084da74c/src/tests/gl_tests/Ble
ndMinMaxTest.cpp

Original comment by bugdroid1@chromium.org on 25 May 2015 at 3:17

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c422207e8145baa25347b26051738bea91ddc2a0

commit c422207e8145baa25347b26051738bea91ddc2a0
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon May 25 17:19:48 2015

Disable some tests due to failures on Intel OpenGL.

BUG=angleproject:884

Change-Id: Iceb571807a2232dae22703953e12e1af4bba5a87
Reviewed-on: https://chromium-review.googlesource.com/273029
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/c422207e8145baa25347b26051738bea91ddc2a0/src/tests/gl_tests/Fra
mebufferFormatsTest.cpp
[modify] 
http://crrev.com/c422207e8145baa25347b26051738bea91ddc2a0/src/tests/gl_tests/Ind
exedPointsTest.cpp
[modify] 
http://crrev.com/c422207e8145baa25347b26051738bea91ddc2a0/src/tests/gl_tests/Tex
tureTest.cpp

Original comment by bugdroid1@chromium.org on 25 May 2015 at 5:23

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/90d98afac1bba7ffc8fb95ec392dbf2c9ab9d82c

commit 90d98afac1bba7ffc8fb95ec392dbf2c9ab9d82c
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue May 26 20:41:38 2015

Bind a texture after creation so that it has a type.

If a texture is bound to a framebuffer before any data is set on it, the
texture does not have a type because it has never been bound.  This
generates an INVALID_OPERATION because the attachment type cannot be
validated.

Fixes:
 * Many generated GL_INVALID_OPERATIONs in chromium

BUG=angleproject:884

Change-Id: I4f36f80fecc5a772b6522f8f82e0be9d3758e524
Reviewed-on: https://chromium-review.googlesource.com/273324
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] 
http://crrev.com/90d98afac1bba7ffc8fb95ec392dbf2c9ab9d82c/src/libANGLE/renderer/
gl/TextureGL.cpp

Original comment by bugdroid1@chromium.org on 27 May 2015 at 1:39

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/6683032d0672998652e76486cc4e914df7dd52f1

commit 6683032d0672998652e76486cc4e914df7dd52f1
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed May 27 20:11:32 2015

Add remaining unsized formats to the GL format tables.

BUG=angleproject:884

Change-Id: I53e7ff9e35b820573691df0d23b41ef45e2a07d0
Reviewed-on: https://chromium-review.googlesource.com/273590
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] 
http://crrev.com/6683032d0672998652e76486cc4e914df7dd52f1/src/libANGLE/renderer/
gl/formatutilsgl.cpp

Original comment by bugdroid1@chromium.org on 29 May 2015 at 7:35

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/fd216c41f7413b7eb4b8009ba26690b37b9a9302

commit fd216c41f7413b7eb4b8009ba26690b37b9a9302
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed May 27 20:12:30 2015

Support BGRA texture by remapping the internal format to RGBA.

The format is still passed as BGRA to the driver so that the data can be
properly unpacked.

BUG=angleproject:884

Change-Id: I767626c818ce1a3c5a4739f07aa623bf8a9ae377
Reviewed-on: https://chromium-review.googlesource.com/273162
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/fd216c41f7413b7eb4b8009ba26690b37b9a9302/src/libANGLE/renderer/
gl/formatutilsgl.h
[modify] 
http://crrev.com/fd216c41f7413b7eb4b8009ba26690b37b9a9302/src/libANGLE/renderer/
gl/formatutilsgl.cpp
[modify] 
http://crrev.com/fd216c41f7413b7eb4b8009ba26690b37b9a9302/src/libANGLE/renderer/
gl/TextureGL.cpp
[modify] 
http://crrev.com/fd216c41f7413b7eb4b8009ba26690b37b9a9302/src/libANGLE/renderer/
gl/RenderbufferGL.cpp

Original comment by bugdroid1@chromium.org on 29 May 2015 at 7:35

GoogleCodeExporter commented 9 years ago

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/bd4cfdcd80ac759944f983bc8a88ffadb581e9f8

commit bd4cfdcd80ac759944f983bc8a88ffadb581e9f8
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Jun 08 13:37:53 2015

Skip LUMA format tests on OpenGL.

These formats are depricated in the core profile and not supported yet.

BUG=angleproject:884

Change-Id: Ic5cf75196ed73cc6bd660fc437f96fdcea5de1b4
Reviewed-on: https://chromium-review.googlesource.com/275771
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/bd4cfdcd80ac759944f983bc8a88ffadb581e9f8/src/tests/gl_tests/Unp
ackAlignmentTest.cpp

Original comment by bugdroid1@chromium.org on 8 Jun 2015 at 1:39

gxquickly / angleproject

Texture objects for the GL back-end #884