search

gxquickly / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Renderbuffer objects for the GL back-end #886

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Implement the RenderbufferGL class.

Original issue reported on code.google.com by geofflang@chromium.org on 22 Jan 2015 at 6:52

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : cd69f1c9c0072d6869c94ff904ec228b7ac94a31

Code-Review  0 : Geoff Lang
Code-Review  +1: Kenneth Russell
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Kenneth Russell
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I7480943d678b2cdf6e997c3f8316acdef32f5f0d
Reviewed-at    : https://chromium-review.googlesource.com/260889

Implement RenderbufferGL.

BUG=angleproject:886

src/libANGLE/Renderbuffer.cpp
src/libANGLE/Renderbuffer.h
src/libANGLE/renderer/gl/FramebufferGL.cpp
src/libANGLE/renderer/gl/RenderbufferGL.cpp
src/libANGLE/renderer/gl/RenderbufferGL.h
src/libANGLE/renderer/gl/RendererGL.cpp
src/libANGLE/renderer/gl/StateManagerGL.cpp
src/libANGLE/renderer/gl/StateManagerGL.h
src/libANGLE/renderer/gl/renderergl_utils.cpp

Original comment by bugdroid1@chromium.org on 27 Mar 2015 at 7:05

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : a08e1bd064fe1e982e182624c3a040609fb816ad

Code-Review  0 : Geoff Lang
Code-Review  +1: Brandon Jones
Code-Review  +2: Kenneth Russell
Verified     0 : Brandon Jones, Kenneth Russell
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I74375351339464b450c2f058adbeed7a1ba18cdd
Reviewed-at    : https://chromium-review.googlesource.com/262125

Split Renderbuffer::setStorage into two functions to match the API.

BUG=angleproject:886

src/libANGLE/Renderbuffer.cpp
src/libANGLE/Renderbuffer.h
src/libANGLE/renderer/RenderbufferImpl.h
src/libANGLE/renderer/d3d/RenderbufferD3D.cpp
src/libANGLE/renderer/d3d/RenderbufferD3D.h
src/libANGLE/renderer/d3d/d3d9/Renderer9.cpp
src/libANGLE/renderer/gl/RenderbufferGL.cpp
src/libANGLE/renderer/gl/RenderbufferGL.h
src/libGLESv2/entry_points_gles_2_0.cpp
src/libGLESv2/entry_points_gles_2_0_ext.cpp
src/libGLESv2/entry_points_gles_3_0.cpp

Original comment by bugdroid1@chromium.org on 27 Mar 2015 at 7:05

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : def624bc0b6229c025a6373d7545af26463e2b2f

Code-Review  0 : Geoff Lang
Code-Review  +1: Jamie Madill
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Jamie Madill
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : Ibcfc2f06e8308e2e6eb1a6c38206b803f689d7af
Reviewed-at    : https://chromium-review.googlesource.com/265470

Move maxSamples from Extensions to Caps because it is an ES3 limit.

BUG=angleproject:886

src/libANGLE/Caps.cpp
src/libANGLE/Caps.h
src/libANGLE/Context.cpp
src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp
src/libANGLE/renderer/d3d/d3d9/renderer9_utils.cpp
src/libANGLE/renderer/gl/renderergl_utils.cpp
src/libANGLE/validationES.cpp

Original comment by bugdroid1@chromium.org on 14 Apr 2015 at 7:35

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : 0d31828f17e4b95248fcaa719dfc426ee81cbee7

Code-Review  0 : Bruce Dawson, Geoff Lang
Code-Review  +2: Jamie Madill
Verified     0 : Bruce Dawson, Jamie Madill
Verified     +1: Geoff Lang
Commit Queue   : Chumped
Change-Id      : I4224ba26fef6783d61a56c294da2bdb6596da7bc
Reviewed-at    : https://chromium-review.googlesource.com/267552

Fixed shadowed error variable.

BUG=angleproject:886

src/libANGLE/renderer/gl/RenderbufferGL.cpp

Original comment by bugdroid1@chromium.org on 27 Apr 2015 at 7:43

GoogleCodeExporter commented 9 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/bf6f48ff065d243a03b1b1e5cd3b1dd6c2c83e48

commit bf6f48ff065d243a03b1b1e5cd3b1dd6c2c83e48
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed May 27 17:54:39 2015

Bind renderbuffers as soon as they are generated.

Like textures, renderbuffers don't become real objects until they are
bound.  If the renderbuffer is never bound before being attached to a
framebuffer, it would generate an INVALID_OPERATION.

Fixes:
 * conformance/textures/tex-input-validation.html
 * conformance/renderbuffers/renderbuffer-initialization.html

BUG=angleproject:886

Change-Id: I639b9e2d9ae694dce29f20ed5f95077ae02d471e
Reviewed-on: https://chromium-review.googlesource.com/273533
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

[modify] 
http://crrev.com/bf6f48ff065d243a03b1b1e5cd3b1dd6c2c83e48/src/libANGLE/renderer/
gl/RenderbufferGL.cpp

Original comment by bugdroid1@chromium.org on 28 May 2015 at 5:55