Open GoogleCodeExporter opened 9 years ago
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 74e160844cfebd8b55ae0ee5f30359de6aa21d94
Code-Review 0 : Corentin Wallez, Geoff Lang
Code-Review +2: Jamie Madill
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : Id6bbc4059f92ff7d8d291583cd30dbd4cd5e9bd3
Reviewed-at : https://chromium-review.googlesource.com/268969
CompilerGL: Use mOutputType when creating the compiler
BUG=angleproject:892
src/libANGLE/renderer/gl/CompilerGL.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 5:57
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : deaee8ba87147506c5cee9b72277efd5f02714b4
Code-Review 0 : Corentin Wallez
Code-Review +2: Jamie Madill
Verified 0 : Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : Ib3b4eb597964c21aba01047e77a413ce19c35855
Reviewed-at : https://chromium-review.googlesource.com/268994
Fix warning about namespacing of HelloTriangle's constructor
BUG=angleproject:892
samples/hello_triangle/HelloTriangle.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 6:00
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 72196b74f00828426026a946c4990c1d883fa97c
Code-Review 0 : Corentin Wallez, Geoff Lang
Code-Review +2: Jamie Madill
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : Iaf175a310ce2acb5a8715902b3d367aa3dae8e2c
Reviewed-at : https://chromium-review.googlesource.com/269124
Add missing trailing newline before EGLWindow.cpp EOF
BUG=angleproject:892
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 6:10
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 75af569cc1e0f9df443e771209115a64551b799e
Code-Review 0 : Corentin Wallez, Geoff Lang
Code-Review +2: Jamie Madill
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I23cfbd9cfbe7d41e048a2b2a4eea048f5de72d12
Reviewed-at : https://chromium-review.googlesource.com/269123
Add missing include in EGLWindow.cpp
BUG=angleproject:892
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 6:10
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : d424da4a4c5f9eb08632738c53ca4604c3b808f1
Code-Review 0 : Corentin Wallez
Code-Review +1: Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : If6f0eb13bca10f9328faeaab35665a67e7ef6e44
Reviewed-at : https://chromium-review.googlesource.com/269122
Fix pointer to int conversion warning in EGLWindow.cpp
BUG=angleproject:892
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 6:10
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : c07c43e43f0ec5dd619f55e06320b8f1542fab77
Code-Review 0 : Corentin Wallez
Code-Review +2: Jamie Madill
Verified 0 : Corentin Wallez
Verified +1: Jamie Madill
Commit Queue : Chumped
Change-Id : Ieb8bb99d02f7050306974db5dab72d26474891ac
Reviewed-at : https://chromium-review.googlesource.com/268996
Revert "Fix pointer to int conversion warning in EGLWindow.cpp"
Causes a compile error.
BUG=angleproject:892
This reverts commit d424da4a4c5f9eb08632738c53ca4604c3b808f1.
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 6:21
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 570dae9ef2d50224c41351882460df54ab8226fb
Code-Review 0 : Corentin Wallez
Code-Review +1: Geoff Lang
Code-Review +2: Jamie Madill
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I23becb235969c6aeda216014fd06880bd7cc5f67
Reviewed-at : https://chromium-review.googlesource.com/269410
Remove noop assignment to configId in DisplayWGL
It is overwritten by ConfigSet::add.
BUG=angleproject:892
src/libANGLE/renderer/gl/wgl/DisplayWGL.cpp
Original comment by bugdroid1@chromium.org
on 5 May 2015 at 7:50
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : fee035018d84cea5d1815a6ba1e66159449afea8
Code-Review 0 : Jamie Madill
Code-Review +2: Corentin Wallez, Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I7b47e26c81dc91900b17a2062bef0ee10c3290aa
Reviewed-at : https://chromium-review.googlesource.com/269209
Move comments next to their code block in FunctionsGL
BUG=angleproject:892
src/libANGLE/renderer/gl/FunctionsGL.cpp
Original comment by bugdroid1@chromium.org
on 5 May 2015 at 7:56
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : cf9dfa493c1c2eb07a0dd9fbaa677e605e4012e0
Code-Review 0 : Corentin Wallez
Code-Review +1: Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : Ia718306226ce6cfcf91f74947a7775b1439e4fab
Reviewed-at : https://chromium-review.googlesource.com/268995
Add missing includes in samples/sample_util/
BUG=angleproject:892
samples/sample_util/Matrix.cpp
samples/sample_util/geometry_utils.h
samples/sample_util/tga_utils.cpp
samples/sample_util/tga_utils.h
Original comment by bugdroid1@chromium.org
on 5 May 2015 at 8:15
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 5adf81824e08ae9644da8846b46fa75331e2ce91
Code-Review 0 : Corentin Wallez, Geoff Lang
Code-Review +2: Jamie Madill
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I88c2724150142415cebf9e45e5747fe2c4889c91
Reviewed-at : https://chromium-review.googlesource.com/269760
Make build/gyp_angle executable
BUG=angleproject:892
build/gyp_angle
Original comment by bugdroid1@chromium.org
on 6 May 2015 at 5:35
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 94b3a078d0a5108d6cf2e1d9fccb1a7954080ea4
Code-Review 0 : Corentin Wallez
Code-Review +1: Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I5e4f80776a558fcdcc7e7b83767145112bcfee98
Reviewed-at : https://chromium-review.googlesource.com/269461
Factor GL extension parsing in renderergl_utils.cpp
DisplayGLX will use it for the GLX extensions too.
BUG=angleproject:892
src/libANGLE/renderer/gl/FunctionsGL.cpp
src/libANGLE/renderer/gl/renderergl_utils.cpp
src/libANGLE/renderer/gl/renderergl_utils.h
Original comment by bugdroid1@chromium.org
on 6 May 2015 at 6:04
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 118e7195fdaa76a1f3aa52bbed30fdb97cc3fd4a
Code-Review 0 : Corentin Wallez
Code-Review +1: Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I2dda3a8d15e58d15a401258a5a64c5783ea1a132
Reviewed-at : https://chromium-review.googlesource.com/269666
EGLWindow: specify the device type only on d3d platform
BUG=angleproject:892
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 7 May 2015 at 3:02
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : fe2f3d634da5316bce8a12d4d7efd03eecf39047
Code-Review 0 : Corentin Wallez, Jamie Madill, Kenneth Russell
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill, Kenneth Russell
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I3f49b68ef9ec5be324b25e211199bac2953ae11e
Reviewed-at : https://chromium-review.googlesource.com/269520
Add a basic support for Linux for utils/
* Timer and path utils are done.
* Window only implements initialize and setVisible
BUG=angleproject:892
util/EGLWindow.cpp
util/linux/LinuxTimer.cpp
util/linux/LinuxTimer.h
util/linux/Linux_path_utils.cpp
util/util.gyp
util/win32/Win32Window.h
util/x11/X11Window.cpp
util/x11/X11Window.h
Original comment by bugdroid1@chromium.org
on 7 May 2015 at 3:02
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 4ea209f129c1dd7cc7354cedf0e044acecb37081
Code-Review 0 : Corentin Wallez
Code-Review +2: Jamie Madill
Verified 0 : Corentin Wallez
Verified +1: Jamie Madill
Commit Queue : Chumped
Change-Id : Ifbb17d1c9bc0390abadbfb8f78cf14dbf1bb8e83
Reviewed-at : https://chromium-review.googlesource.com/269950
Revert "EGLWindow: specify the device type only on d3d platform"
Causing failures in EGLSurfaceTest.MakeCurrentTwice on Windows
BUG=angleproject:892
This reverts commit 118e7195fdaa76a1f3aa52bbed30fdb97cc3fd4a.
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 7 May 2015 at 3:33
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : ec0b13622a33bbcdae2371af7cca97c19fd25412
Code-Review 0 : Corentin Wallez
Code-Review +1: Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I1ad366e16b135649fe1b0351081f9971db84df50
Reviewed-at : https://chromium-review.googlesource.com/269665
Make util/win32 follow ANGLE conventions better
BUG=angleproject:892
util/win32/Win32Timer.cpp
util/win32/Win32Timer.h
util/win32/Win32Window.cpp
util/win32/Win32Window.h
util/win32/Win32_path_utils.cpp
Original comment by bugdroid1@chromium.org
on 7 May 2015 at 5:22
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : bf9e40509a9f36321fe5326e5b0942005ba42122
Code-Review 0 : Corentin Wallez, Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I0406e26910f5a012ccb9e533af18e831522161b1
Reviewed-at : https://chromium-review.googlesource.com/269827
EGLWindow: specify the device type only on d3d platform
BUG=angleproject:892
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 7 May 2015 at 5:50
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 6db6e0ae81bb52fd77c31aa0463ca0b46b7bda1c
Code-Review 0 : Corentin Wallez, Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I0fa089f299abaab406384a05b096de19f04f3a5e
Reviewed-at : https://chromium-review.googlesource.com/269829
eglGetPlatformDisplayEXT: validate device types are set only on d3d
BUG=angleproject:892
src/libGLESv2/entry_points_egl_ext.cpp
Original comment by bugdroid1@chromium.org
on 7 May 2015 at 5:51
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 06394f667b74aaf8a5fd67fc4f4c83e77244648c
Code-Review 0 : Corentin Wallez, Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : If09cf30122d97590f07447147e6d54c2e4157f9e
Reviewed-at : https://chromium-review.googlesource.com/269828
EGLSurfaceTest: specify the device type only on d3d platform
BUG=angleproject:892
src/tests/standalone_tests/EGLSurfaceTest.cpp
Original comment by bugdroid1@chromium.org
on 7 May 2015 at 5:51
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 2cf30bd09c1c1eede7fc088c790d20a334a1e7b9
Code-Review 0 : Corentin Wallez, Geoff Lang
Code-Review +1: Kenneth Russell
Code-Review +2: Jamie Madill
Verified 0 : Geoff Lang, Jamie Madill, Kenneth Russell
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I6d88efeb4ec5de7a78cb3668e3d78520203ad1d5
Reviewed-at : https://chromium-review.googlesource.com/269990
Fix GetExecutablePath on Linux
It was using lstat to get the size of /proc/self/exe but
it always returns 0, so we just use a big buffer on the
stack instead.
BUG=angleproject:892
util/linux/Linux_path_utils.cpp
Original comment by bugdroid1@chromium.org
on 8 May 2015 at 5:15
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 98e7d0710aadef39d4aeb5f6da330d8cefa9f291
Code-Review 0 : Corentin Wallez
Code-Review +1: Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I70c431b3c1ba78c3ce7844d7f276cc19ac17d7f5
Reviewed-at : https://chromium-review.googlesource.com/269999
Use a D3D11 renderer by default, when available.
Also update SampleApplication to request the default
renderer instead of explicitely asking for d3d11
BUG=angleproject:892
samples/sample_util/SampleApplication.h
src/libANGLE/renderer/d3d/DisplayD3D.cpp
Original comment by bugdroid1@chromium.org
on 8 May 2015 at 5:52
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 9477dc94c0af4f2ecf128c4d09b6a9f9d6743ad2
Code-Review +1: Jamie Madill
Code-Review +2: Corentin Wallez, Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I1ef1bd0ce60f4585e473f9750c748a1b41c09da2
Reviewed-at : https://chromium-review.googlesource.com/269741
Add GLX EGL implementation stubs
BUG=angleproject:892
src/angle.gyp
src/libANGLE/Display.cpp
src/libANGLE/renderer/gl/glx/DisplayGLX.cpp
src/libANGLE/renderer/gl/glx/DisplayGLX.h
src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.cpp
src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.h
src/libGLESv2.gypi
Original comment by bugdroid1@chromium.org
on 8 May 2015 at 9:16
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 12a8e86685811d94a1b5ff357134ce495587a281
Code-Review +1: Jamie Madill
Code-Review +2: Corentin Wallez, Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I401a7ef4fd055eda7276bd34dcf0fc6ae0deff13
Reviewed-at : https://chromium-review.googlesource.com/270124
Make all the samples compile under Linux
Two-thirds of them run and work well.
BUG=angleproject:892
samples/mip_map_2d/MipMap2D.cpp
samples/multi_texture/MultiTexture.cpp
samples/multi_window/MultiWindow.cpp
samples/multiple_draw_buffers/MultipleDrawBuffers.cpp
samples/particle_system/ParticleSystem.cpp
samples/post_sub_buffer/PostSubBuffer.cpp
samples/samples.gyp
samples/simple_instancing/SimpleInstancing.cpp
samples/simple_texture_2d/SimpleTexture2D.cpp
samples/simple_texture_cubemap/SimpleTextureCubemap.cpp
samples/simple_vertex_shader/SimpleVertexShader.cpp
samples/stencil_operations/StencilOperations.cpp
samples/tex_redef_microbench/TexRedefMicroBench.cpp
samples/texture_wrap/TextureWrap.cpp
samples/tri_fan_microbench/TriFanMicroBench.cpp
Original comment by bugdroid1@chromium.org
on 11 May 2015 at 2:52
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : 12fe4dc8ce23549a7b8d95245cb4abf7ba3cce87
Code-Review 0 : Corentin Wallez
Code-Review +1: Jamie Madill
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : Ic40f29c811d18efea0e081c269ca43d0170488a4
Reviewed-at : https://chromium-review.googlesource.com/270125
Fix pointer to int conversion warning in EGLWindow.cpp
BUG=angleproject:892
util/EGLWindow.cpp
Original comment by bugdroid1@chromium.org
on 11 May 2015 at 3:00
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : eac646338ccb295063085f7e810e6a5c76135e45
Code-Review 0 : Corentin Wallez, Jamie Madill, Kenneth Russell
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill, Kenneth Russell
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : Ife9955a457d4a6fb3adce17757ccb0de7d0dd274
Reviewed-at : https://chromium-review.googlesource.com/269413
Add a basic GLX EGL implementation
BUG=angleproject:892
src/libANGLE/renderer/gl/glx/DisplayGLX.cpp
src/libANGLE/renderer/gl/glx/DisplayGLX.h
src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.cpp
src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.h
src/libANGLE/renderer/gl/glx/platform_glx.h
src/libGLESv2.gypi
Original comment by bugdroid1@chromium.org
on 11 May 2015 at 4:36
Project: angle/angle
Branch : master
Author : Corentin Wallez <cwallez@chromium.org>
Commit : f229cb9bf65a5945c0e6012ab9f47f02ab2eedb9
Code-Review 0 : Corentin Wallez, Jamie Madill, Kenneth Russell
Code-Review +2: Geoff Lang
Verified 0 : Geoff Lang, Jamie Madill, Kenneth Russell
Verified +1: Corentin Wallez
Commit Queue : Chumped
Change-Id : I516b7d859100cb065871de8e328585a9ca817499
Reviewed-at : https://chromium-review.googlesource.com/270123
Add a FunctionsGLX class to dynamically load the GLX entry points
BUG=angleproject:892
src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp
src/libANGLE/renderer/gl/glx/FunctionsGLX.h
src/libANGLE/renderer/gl/glx/WindowSurfaceGLX.h
src/libANGLE/renderer/gl/glx/functionsglx_typedefs.h
src/libANGLE/renderer/gl/glx/platform_glx.h
src/libGLESv2.gypi
Original comment by bugdroid1@chromium.org
on 11 May 2015 at 4:36
[deleted comment]
[deleted comment]
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/01f4062c03806c07a5038f137b741c5f425542bb
commit 01f4062c03806c07a5038f137b741c5f425542bb
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri May 22 18:30:28 2015
Revert "Add an end2end test checking EGL context-surface compatibility"
Failing due to a bug in the test:
BUG=angleproject:892
This reverts commit 08971bff3e24b516fcfd5327a51801bc270d3987.
Change-Id: I5f97f5e00f8b820874d575421b9a50829bb6f1e0
Reviewed-on: https://chromium-review.googlesource.com/272912
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
[modify]
http://crrev.com/01f4062c03806c07a5038f137b741c5f425542bb/src/tests/angle_end2en
d_tests.gypi
[delete]
http://crrev.com/4f5659ae56f529980ba36eed404cc98e8ae88677/src/tests/egl_tests/EG
LContextCompatibilityTest.cpp
Original comment by bugdroid1@chromium.org
on 22 May 2015 at 6:30
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/3a1f367332fcb62d5852fb890e54311044aee9c4
commit 3a1f367332fcb62d5852fb890e54311044aee9c4
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed May 20 15:12:16 2015
Add an end2end test checking EGL context-surface compatibility
This has been very useful to figure out the FBConfig story for the GLX
EGL implementation.
BUG=angleproject:892
Change-Id: Ie4138dd1dd98f1450984a61317e3fc863c620ad3
Reviewed-on: https://chromium-review.googlesource.com/272371
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/272907
[modify]
http://crrev.com/3a1f367332fcb62d5852fb890e54311044aee9c4/src/tests/angle_end2en
d_tests.gypi
[add]
http://crrev.com/3a1f367332fcb62d5852fb890e54311044aee9c4/src/tests/egl_tests/EG
LContextCompatibilityTest.cpp
Original comment by bugdroid1@chromium.org
on 22 May 2015 at 6:53
Original comment by bugdroid1@chromium.org
on 22 May 2015 at 8:06
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/f4863b70006ce1c825b9899652ec6e91c6593331
commit f4863b70006ce1c825b9899652ec6e91c6593331
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu May 21 20:29:36 2015
Implement swapInterval for EGL on GLX
BUG=angleproject:892
Change-Id: I80d8d67270662c7f2be893f4a8318fbc0926f1fc
Reviewed-on: https://chromium-review.googlesource.com/272677
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/f4863b70006ce1c825b9899652ec6e91c6593331/src/libANGLE/renderer/
gl/glx/WindowSurfaceGLX.h
[modify]
http://crrev.com/f4863b70006ce1c825b9899652ec6e91c6593331/src/libANGLE/renderer/
gl/glx/DisplayGLX.cpp
[modify]
http://crrev.com/f4863b70006ce1c825b9899652ec6e91c6593331/src/libANGLE/renderer/
gl/glx/WindowSurfaceGLX.cpp
[modify]
http://crrev.com/f4863b70006ce1c825b9899652ec6e91c6593331/src/libANGLE/renderer/
gl/glx/FunctionsGLX.cpp
[modify]
http://crrev.com/f4863b70006ce1c825b9899652ec6e91c6593331/src/libANGLE/renderer/
gl/glx/platform_glx.h
[modify]
http://crrev.com/f4863b70006ce1c825b9899652ec6e91c6593331/src/libANGLE/renderer/
gl/glx/FunctionsGLX.h
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 2:44
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/1ca3d015d9d9e36e551d3acfa7baee03627b07cd
commit 1ca3d015d9d9e36e551d3acfa7baee03627b07cd
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri May 22 17:35:35 2015
Simplify the implementation of ANGLE_INSTANTIATE_TEST
I mistakenly submitted a refactor with +2 but not +1 so a comment wasn't
addressed, hopefully fixes it.
BUG=angleproject:892
Change-Id: I096c2424449be196dfa949cc6ef662b766036330
Reviewed-on: https://chromium-review.googlesource.com/272905
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/1ca3d015d9d9e36e551d3acfa7baee03627b07cd/src/tests/test_utils/a
ngle_test_instantiate.h
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 3:04
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/642488e5f3e44567eca23d00c89eef11b45801b3
commit 642488e5f3e44567eca23d00c89eef11b45801b3
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri May 22 20:05:56 2015
Poll all windows in the multi window sample
On Linux all windows are polled separately contrary to windows in which
the callback is used on all windows.
BUG=angleproject:892
Change-Id: Ib1538f12ab2fa1864d29c91b9c5bfc2204cd1fa7
Reviewed-on: https://chromium-review.googlesource.com/272945
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/642488e5f3e44567eca23d00c89eef11b45801b3/samples/multi_window/M
ultiWindow.cpp
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 3:05
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/3d5cb77456b0633b3ebd595c7387d29e776a3b7f
commit 3d5cb77456b0633b3ebd595c7387d29e776a3b7f
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri May 22 21:19:45 2015
Enable EGLSurfaceTest on Linux
BUG=angleproject:892
Change-Id: I142ab37e00e2ba7fc2316aff564cc449eeb22771
Reviewed-on: https://chromium-review.googlesource.com/273130
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/3d5cb77456b0633b3ebd595c7387d29e776a3b7f/src/tests/egl_tests/EG
LSurfaceTest.cpp
[modify]
http://crrev.com/3d5cb77456b0633b3ebd595c7387d29e776a3b7f/src/tests/angle_end2en
d_tests.gypi
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 3:06
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/db39e7f5dd38c5bdbff08c929288350e643eb0bc
commit db39e7f5dd38c5bdbff08c929288350e643eb0bc
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon May 25 13:51:24 2015
Rename path_utils to system_utils
For inclusion of Sleep
BUG=angleproject:892
Change-Id: I1a9491102e9943d945eef0ba372a6779c30cd311
Reviewed-on: https://chromium-review.googlesource.com/273131
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/db39e7f5dd38c5bdbff08c929288350e643eb0bc/samples/particle_syste
m/ParticleSystem.cpp
[rename]
http://crrev.com/db39e7f5dd38c5bdbff08c929288350e643eb0bc/util/linux/Linux_syste
m_utils.cpp
[rename]
http://crrev.com/db39e7f5dd38c5bdbff08c929288350e643eb0bc/util/system_utils.h
[modify] http://crrev.com/db39e7f5dd38c5bdbff08c929288350e643eb0bc/util/util.gyp
[modify]
http://crrev.com/db39e7f5dd38c5bdbff08c929288350e643eb0bc/samples/multi_texture/
MultiTexture.cpp
[rename]
http://crrev.com/db39e7f5dd38c5bdbff08c929288350e643eb0bc/util/win32/Win32_syste
m_utils.cpp
[modify]
http://crrev.com/db39e7f5dd38c5bdbff08c929288350e643eb0bc/samples/multiple_draw_
buffers/MultipleDrawBuffers.cpp
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 3:07
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/1ee5b60a14bd1125cc5d448802d4b8803efc19c2
commit 1ee5b60a14bd1125cc5d448802d4b8803efc19c2
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon May 25 15:15:53 2015
Merge separate definitions of include_dirs for perftests
BUG=angleproject:892
Change-Id: Ifd108b3119ea73c05e984ca9138536fb8cf6839c
Reviewed-on: https://chromium-review.googlesource.com/273137
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/1ee5b60a14bd1125cc5d448802d4b8803efc19c2/src/tests/angle_perfte
sts.gypi
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 3:20
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/3d5cb77456b0633b3ebd595c7387d29e776a3b7f
commit 3d5cb77456b0633b3ebd595c7387d29e776a3b7f
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri May 22 21:19:45 2015
Enable EGLSurfaceTest on Linux
BUG=angleproject:892
Change-Id: I142ab37e00e2ba7fc2316aff564cc449eeb22771
Reviewed-on: https://chromium-review.googlesource.com/273130
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/3d5cb77456b0633b3ebd595c7387d29e776a3b7f/src/tests/egl_tests/EG
LSurfaceTest.cpp
[modify]
http://crrev.com/3d5cb77456b0633b3ebd595c7387d29e776a3b7f/src/tests/angle_end2en
d_tests.gypi
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 4:50
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/b2b6dfaf9599e58e5432540cfe0d48f88a846173
commit b2b6dfaf9599e58e5432540cfe0d48f88a846173
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon May 25 19:31:13 2015
Use absolute paths in angle_perftests.gypi
Otherwise in the Chromium build gyp might have a wrong cwd and then ninja
will fail to find the files to compile.
BUG=angleproject:892
Change-Id: I6b7beef5ecad62cc345b49253cedbde0ac166c17
Reviewed-on: https://chromium-review.googlesource.com/273161
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
[modify]
http://crrev.com/b2b6dfaf9599e58e5432540cfe0d48f88a846173/src/tests/angle_perfte
sts.gypi
Original comment by bugdroid1@chromium.org
on 25 May 2015 at 8:02
Commits fe2f3d634da5316bce8a12d4d7efd03eecf39047 and
eac646338ccb295063085f7e810e6a5c76135e45 have broken Linux builds that do not
have X (such as some Ozone ones), as they introduce a hardcoded dependency on
libX11 and libXi.
Can those dependencies be made optional?
Original comment by raphael.kubo.da.costa@intel.com
on 26 May 2015 at 10:21
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/aaa9eb942713894006f362780aff0da846285530
commit aaa9eb942713894006f362780aff0da846285530
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri May 22 20:08:08 2015
WindowSurfaceGLX handle resizing the window on swap
This make the multi window sample work well.
BUG=angleproject:892
Change-Id: If98c6f995875b63c391cee9b6fddc6d138d48f8b
Reviewed-on: https://chromium-review.googlesource.com/272946
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/aaa9eb942713894006f362780aff0da846285530/src/libANGLE/renderer/
gl/glx/WindowSurfaceGLX.cpp
[modify]
http://crrev.com/aaa9eb942713894006f362780aff0da846285530/src/libANGLE/renderer/
gl/glx/WindowSurfaceGLX.h
Original comment by bugdroid1@chromium.org
on 26 May 2015 at 1:04
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/e6d82c6de827854682726972c86deb6bbed3582d
commit e6d82c6de827854682726972c86deb6bbed3582d
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon May 25 18:40:54 2015
Fix order of TearDown of EGLSurfaceTest
Previously the OS window was deleted before the EGL window surface which
caused the GLX window to be deleted after its X window was deleted. All
this was invalid and resulted in a crash.
BUG=angleproject:892
Change-Id: I394795b6ebce947ad7eeab9a70ad5f80fcd89241
Reviewed-on: https://chromium-review.googlesource.com/273055
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/e6d82c6de827854682726972c86deb6bbed3582d/src/tests/egl_tests/EG
LSurfaceTest.cpp
Original comment by bugdroid1@chromium.org
on 26 May 2015 at 1:05
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/5c798fe97d8f6a577eb804bd1453317778533b99
commit 5c798fe97d8f6a577eb804bd1453317778533b99
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon May 25 14:03:35 2015
Enable OcclusionQueriesTest on Linux
This includes an implementation of a cross platform Sleep function
BUG=angleproject:892
Change-Id: I1087a00ab204b37bafc5e95a9766962b194d97ef
Reviewed-on: https://chromium-review.googlesource.com/273133
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[add]
http://crrev.com/5c798fe97d8f6a577eb804bd1453317778533b99/util/posix/Posix_syste
m_utils.cpp
[modify]
http://crrev.com/5c798fe97d8f6a577eb804bd1453317778533b99/util/system_utils.h
[modify] http://crrev.com/5c798fe97d8f6a577eb804bd1453317778533b99/util/util.gyp
[modify]
http://crrev.com/5c798fe97d8f6a577eb804bd1453317778533b99/src/tests/gl_tests/Occ
lusionQueriesTest.cpp
[modify]
http://crrev.com/5c798fe97d8f6a577eb804bd1453317778533b99/util/win32/Win32_syste
m_utils.cpp
[modify]
http://crrev.com/5c798fe97d8f6a577eb804bd1453317778533b99/src/tests/angle_end2en
d_tests.gypi
Original comment by bugdroid1@chromium.org
on 27 May 2015 at 2:29
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/44aedf377fea39ebdd098c105c41a5f4b786c864
commit 44aedf377fea39ebdd098c105c41a5f4b786c864
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon May 25 18:41:51 2015
Enable PbufferTest on Linux by not advertising bindable configs
GLX Pbuffers are not bindable so implementing bindable pbuffers would
have to be one of the following:
- Implement Pbuffer as GLXPixmaps, with complication arising in the
initialization.
- Implement Pbuffers as GL textures, which would require a large change
of the EGL implementation.
- Fake bindable Pbuffers with glCopyTexImage2D, with obvious
performance problems.
BUG=angleproject:892
Change-Id: I7d9cd5a4aa2d35343244be3cbe55fc1e492f6928
Reviewed-on: https://chromium-review.googlesource.com/273056
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/44aedf377fea39ebdd098c105c41a5f4b786c864/src/tests/angle_end2en
d_tests.gypi
[modify]
http://crrev.com/44aedf377fea39ebdd098c105c41a5f4b786c864/src/libANGLE/renderer/
gl/glx/DisplayGLX.cpp
Original comment by bugdroid1@chromium.org
on 27 May 2015 at 2:32
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/c6a61c27e6c4f25d555fbcbd37f6d8dbdf958a39
commit c6a61c27e6c4f25d555fbcbd37f6d8dbdf958a39
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Jun 08 20:41:57 2015
Fix standalone compilation on Linux
BUG=angleproject:892
Change-Id: Iceae30f5bc12546b2486e8aac0346eab1f09ded3
Reviewed-on: https://chromium-review.googlesource.com/276200
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify] http://crrev.com/c6a61c27e6c4f25d555fbcbd37f6d8dbdf958a39/src/angle.gyp
Original comment by bugdroid1@chromium.org
on 10 Jun 2015 at 6:27
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/44b07e9498bd78d5c180c45c699492981e21965c
commit 44b07e9498bd78d5c180c45c699492981e21965c
Author: Corentin Wallez <cwallez@chromium.org>
Date: Tue Jun 09 16:00:46 2015
Fix compilation of libtester_main on Linux
Replace usage of std::exception by std::runtime_error
BUG=angleproject:892
Change-Id: I214fe6a93944dcfb39b0633f46caf3b1187bd5d3
Reviewed-on: https://chromium-review.googlesource.com/275815
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/44b07e9498bd78d5c180c45c699492981e21965c/src/tests/deqp_support
/angle_deqp_libtester_main.cpp
Original comment by bugdroid1@chromium.org
on 11 Jun 2015 at 2:11
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/fd0957d9949ea083d6b60cfbe0e0c83073d955f3
commit fd0957d9949ea083d6b60cfbe0e0c83073d955f3
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Jun 17 16:26:24 2015
Fix standalone compilation on Linux
Use a "gyp trick" to define a default value for use_x11, thanks goes to
kbr for remembering the other instance of this trick.
BUG=angleproject:892
Change-Id: Ifb64af4e56d9eb90993760a495008d95dd31ae3d
Reviewed-on: https://chromium-review.googlesource.com/278158
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify] http://crrev.com/fd0957d9949ea083d6b60cfbe0e0c83073d955f3/src/angle.gyp
Original comment by bugdroid1@chromium.org
on 17 Jun 2015 at 10:37
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8
commit 322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Jun 17 16:33:56 2015
Fix Chromium build of angle_end2end_tests
BUG=angleproject:892
Change-Id: I9922046fc9e4d82d7034405f5952263f982c6529
Reviewed-on: https://chromium-review.googlesource.com/278159
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Tex
tureTest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Fen
ceSyncTests.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/libGLESv2.gypi
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/test_utils/A
NGLETest.h
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/libEGL.gypi
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Occ
lusionQueriesTest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Mip
mapTest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Dis
cardFramebufferEXTTest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Tra
nsformFeedbackTest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Max
TextureSizeTest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/libANGLE/renderer/
gl/formatutilsgl.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Bli
tFramebufferANGLETest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Rea
dPixelsTest.cpp
[modify]
http://crrev.com/322653bfe00b88a81d3a93e2dc9003e7dbc5a8a8/src/tests/gl_tests/Buf
ferDataTest.cpp
Original comment by bugdroid1@chromium.org
on 17 Jun 2015 at 10:37
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/e1a5518e4d3c1da79d2a584aa9c80ce5dca6b8ca
commit e1a5518e4d3c1da79d2a584aa9c80ce5dca6b8ca
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Jun 18 17:20:55 2015
Fix defines being exported outside of ANGLE
This should fix a build failure on a GPU try bot so we can Roll ANGLE
BUG=angleproject:892
Change-Id: I86cb0135dc71b003f691633e339d5d0527eaace4
Reviewed-on: https://chromium-review.googlesource.com/280396
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/e1a5518e4d3c1da79d2a584aa9c80ce5dca6b8ca/src/libEGL.gypi
[modify]
http://crrev.com/e1a5518e4d3c1da79d2a584aa9c80ce5dca6b8ca/src/libGLESv2.gypi
Original comment by bugdroid1@chromium.org
on 18 Jun 2015 at 6:48
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/4ffd7790310207a64c9eb8c2f3485be05d3b030c
commit 4ffd7790310207a64c9eb8c2f3485be05d3b030c
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Jun 11 13:28:33 2015
DisplayGLX: add error checking for the dummy pbuffer creation
BUG=angleproject:892
Change-Id: I7a15f2be19a598e40d4fa5a7c70d879cdbc6d32a
Reviewed-on: https://chromium-review.googlesource.com/277011
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/4ffd7790310207a64c9eb8c2f3485be05d3b030c/src/libANGLE/renderer/
gl/glx/DisplayGLX.cpp
Original comment by bugdroid1@chromium.org
on 18 Jun 2015 at 10:37
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/f0c1d0292d2f04e82ed0aea80359a85f32672a4e
commit f0c1d0292d2f04e82ed0aea80359a85f32672a4e
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Jun 19 01:37:09 2015
Fix compilation errors and Mac and some try bots
BUG=angleproject:892
Change-Id: I9a449889109b7df9c69776573b0fc2098cd06199
Reviewed-on: https://chromium-review.googlesource.com/280565
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
[modify]
http://crrev.com/f0c1d0292d2f04e82ed0aea80359a85f32672a4e/src/tests/gl_tests/Poi
ntSpritesTest.cpp
[modify]
http://crrev.com/f0c1d0292d2f04e82ed0aea80359a85f32672a4e/src/tests/perf_tests/P
ointSprites.cpp
[modify]
http://crrev.com/f0c1d0292d2f04e82ed0aea80359a85f32672a4e/samples/multi_window/M
ultiWindow.cpp
Original comment by bugdroid1@chromium.org
on 19 Jun 2015 at 1:45
Original issue reported on code.google.com by
geofflang@chromium.org
on 22 Jan 2015 at 7:10