Closed GoogleCodeExporter closed 9 years ago
https://chromium-review.googlesource.com/#/c/243892/2
Original comment by Gregory....@imgtec.com
on 28 Jan 2015 at 4:13
Original comment by geofflang@chromium.org
on 29 Apr 2015 at 7:19
Project: angle/angle
Branch : master
Author : Geoff Lang <geofflang@chromium.org>
Commit : 942e36254a1e3537371c39f3f23d1ce12f4c87e8
Code-Review 0 : Geoff Lang
Code-Review +1: Zhenyao Mo
Code-Review +2: Jamie Madill
Verified 0 : Jamie Madill, Zhenyao Mo
Verified +1: Geoff Lang
Commit Queue : Chumped
Change-Id : I77054d04c9935eedcdbb7304dc0c3b60b53994f9
Reviewed-at : https://chromium-review.googlesource.com/268434
Don't mark all macros with double underscores as reserved.
Only __FILE__, __LINE__, __VERSION__ and GL_ES are reserved but it is
still not recommended to use a name with double underscores because it may
be used by the "underlying software layers".
Updated the tests to reflect that it is OK to define macros with double
underscores but it is not valid to make assumptions about their values.
Fixes:
dEQP-GLES2.functional.shaders.preprocessor.basic.identifier_with_double_undersco
re_vertex
dEQP-GLES2.functional.shaders.preprocessor.basic.identifier_with_double_undersco
re_fragment
BUG=angleproject:898
src/compiler/preprocessor/DirectiveParser.cpp
src/tests/preprocessor_tests/define_test.cpp
Original comment by bugdroid1@chromium.org
on 1 May 2015 at 2:32
Original issue reported on code.google.com by
Gregory....@imgtec.com
on 27 Jan 2015 at 6:48