Closed GoogleCodeExporter closed 9 years ago
Original comment by cwal...@chromium.org
on 12 Mar 2015 at 5:51
[deleted comment]
Original comment by oetu...@nvidia.com
on 18 Mar 2015 at 12:23
Project: angle/angle
Branch : master
Author : Olli Etuaho <oetuaho@nvidia.com>
Commit : b2983c9558c5793cdb668fe49f3d5798f95c36d2
Code-Review 0 : Corentin Wallez, Nicolas Capens, Olli Etuaho, Zhenyao Mo
Code-Review +2: Jamie Madill
Verified 0 : Corentin Wallez, Jamie Madill, Nicolas Capens, Zhenyao Mo
Verified +1: Olli Etuaho
Commit Queue : Chumped
Change-Id : I2dadde9dcc01c7a4a653c1982c36377b89e6d437
Reviewed-at : https://chromium-review.googlesource.com/260800
Correctly insert unmangled function names to symbol table
This fixes detecting some cases of function parameter mismatch
(previously a mangled function name corresponding to no function
parameters was added to the symbol table for each user-defined function,
and this was returned when doing function lookups with no parameters).
Also fixes detection of reusing a function name as a variable/struct
name.
New unit tests are added to ensure that these fixes don't regress.
BUG=angleproject:936
TEST=angle_unittests, WebGL conformance tests
src/compiler/translator/SymbolTable.cpp
src/compiler/translator/SymbolTable.h
src/compiler/translator/glslang.y
src/compiler/translator/glslang_tab.cpp
src/tests/angle_unittests.gypi
src/tests/compiler_tests/MalformedShader_test.cpp
Original comment by bugdroid1@chromium.org
on 19 Mar 2015 at 2:37
Original comment by oetu...@nvidia.com
on 19 Mar 2015 at 4:55
Original issue reported on code.google.com by
oetu...@nvidia.com
on 5 Mar 2015 at 3:16