gxquickly / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Version directive is missing from ESSL3 output #953

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to translate an ESSL3 shader into ESSL with the shader translator.

What is the expected output? What do you see instead?
Expected: Shader starts with "#version 300 es"
Actual: Shader lacks a version directive.

This is a simple omission from TranslatorESSL.

The problem is noticeable in the current version of Chromium for Windows, which 
translates shaders first from ESSL to ESSL and then from ESSL to HLSL.

Original issue reported on code.google.com by oetu...@nvidia.com on 19 Mar 2015 at 2:52

GoogleCodeExporter commented 9 years ago
Project: angle/angle
Branch : master
Author : Olli Etuaho <oetuaho@nvidia.com>
Commit : 1ade24db74628152da0f84ff0ebd4ff2549eb7d5

Code-Review  0 : Nicolas Capens, Olli Etuaho
Code-Review  +1: Jamie Madill
Code-Review  +2: Zhenyao Mo
Verified     0 : Jamie Madill, Nicolas Capens, Zhenyao Mo
Verified     +1: Olli Etuaho
Commit Queue   : Chumped
Change-Id      : Ib9e45fab1d35f8c78abd0ac2209ac4f63afe4465
Reviewed-at    : https://chromium-review.googlesource.com/261170

Add #version 300 es to ESSL output when needed

BUG=angleproject:953

src/compiler/translator/TranslatorESSL.cpp

Original comment by bugdroid1@chromium.org on 19 Mar 2015 at 4:50

GoogleCodeExporter commented 9 years ago

Original comment by oetu...@nvidia.com on 19 Mar 2015 at 4:54