search

gxquickly / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Setting ANGLE_TEST_CONFIG doesn't affect compilerdebug.h #983

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Set #define ANGLE_TEST_CONFIG

What is the expected output? What do you see instead?
Expected: UNIMPLEMENTED asserts are disabled
Actual: UNIMPLEMENTED asserts are not disabled in compiler

Suggested fix is to merge compilerdebug.h and debug.h

Original issue reported on code.google.com by oetu...@nvidia.com on 24 Apr 2015 at 1:15

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Olli Etuaho <oetuaho@nvidia.com>
Commit : 5271025865b34685da71d0309131c5aff2e32f71

Code-Review  0 : Geoff Lang, Olli Etuaho
Code-Review  +1: Jamie Madill
Code-Review  +2: Zhenyao Mo
Verified     0 : Geoff Lang, Jamie Madill, Zhenyao Mo
Verified     +1: Olli Etuaho
Commit Queue   : Chumped
Change-Id      : Ifca4d16f667b1e5cf9c2e7cc4139940091917a1c
Reviewed-at    : https://chromium-review.googlesource.com/266993

Remove separate compilerdebug.h in favor of debug.h

This unifies the behavior across the compiler and rest of ANGLE - for
example, one can use #define ANGLE_TEST_CONFIG to disable UNIMPLEMENTED
asserts in both the compiler and the rest of ANGLE. Compiler traces from
asserts also go to the same TRACE_OUTPUT_FILE as other traces instead of
being directed through ParseContext.

The compiler build already includes the common sources, so no changes to
build config are needed.

TEST=angle_unittests, angle_end2end_tests,
     dEQP-GLES3.functional.shaders.*
BUG=angleproject:983

src/compiler.gypi
src/compiler/translator/BaseTypes.h
src/compiler/translator/Common.h
src/compiler/translator/Diagnostics.cpp
src/compiler/translator/Diagnostics.h
src/compiler/translator/DirectiveHandler.cpp
src/compiler/translator/InitializeVariables.cpp
src/compiler/translator/OutputGLSLBase.cpp
src/compiler/translator/OutputHLSL.cpp
src/compiler/translator/ParseContext.cpp
src/compiler/translator/ParseContext.h
src/compiler/translator/RegenerateStructNames.cpp
src/compiler/translator/ScalarizeVecAndMatConstructorArgs.cpp
src/compiler/translator/ShaderVars.cpp
src/compiler/translator/Types.h
src/compiler/translator/compilerdebug.cpp
src/compiler/translator/compilerdebug.h

Original comment by bugdroid1@chromium.org on 27 Apr 2015 at 9:29

GoogleCodeExporter commented 9 years ago

Original comment by oetu...@nvidia.com on 27 Apr 2015 at 9:55

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Olli Etuaho <oetuaho@nvidia.com>
Commit : d57e0db35ee4f35f67b70bd1b44c1609083328cd

Code-Review  0 : Zhenyao Mo
Code-Review  +2: Jamie Madill, Olli Etuaho
Verified     0 : Jamie Madill, Zhenyao Mo
Verified     +1: Olli Etuaho
Commit Queue   : Chumped
Change-Id      : I36929020a04251b8bc834fbb3c069e10128c3082
Reviewed-at    : https://chromium-review.googlesource.com/267411

Remove separate compilerdebug.h in favor of debug.h

This unifies the behavior across the compiler and rest of ANGLE - for
example, one can use #define ANGLE_TEST_CONFIG to disable UNIMPLEMENTED
asserts in both the compiler and the rest of ANGLE. Compiler traces from
asserts also go to the same TRACE_OUTPUT_FILE as other traces instead of
being directed through ParseContext.

The compiler build already includes the common sources, so no changes to
build config are needed.

The original version of this change was reverted due to release mode
build issues. This version adds UNUSED_ASSERTION_VARIABLE where needed.

TEST=angle_unittests, angle_end2end_tests,
     dEQP-GLES3.functional.shaders.*
BUG=angleproject:983

src/compiler.gypi
src/compiler/translator/BaseTypes.h
src/compiler/translator/CallDAG.cpp
src/compiler/translator/Common.h
src/compiler/translator/Diagnostics.cpp
src/compiler/translator/Diagnostics.h
src/compiler/translator/DirectiveHandler.cpp
src/compiler/translator/InitializeVariables.cpp
src/compiler/translator/IntermNode.cpp
src/compiler/translator/OutputGLSLBase.cpp
src/compiler/translator/OutputHLSL.cpp
src/compiler/translator/ParseContext.cpp
src/compiler/translator/ParseContext.h
src/compiler/translator/RegenerateStructNames.cpp
src/compiler/translator/ScalarizeVecAndMatConstructorArgs.cpp
src/compiler/translator/ShaderVars.cpp
src/compiler/translator/Types.h
src/compiler/translator/compilerdebug.cpp
src/compiler/translator/compilerdebug.h

Original comment by bugdroid1@chromium.org on 27 Apr 2015 at 3:12