Closed GoogleCodeExporter closed 9 years ago
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : b11e2483742db884bd0af41f78f528240577356b
Code-Review 0 : Jamie Madill
Code-Review +1: Kenneth Russell
Code-Review +2: Zhenyao Mo
Verified 0 : Kenneth Russell, Zhenyao Mo
Verified +1: Jamie Madill
Commit Queue : Chumped
Change-Id : I110efaf1b7b0158b08b704277e3bc2472437902c
Reviewed-at : https://chromium-review.googlesource.com/268962
translator: Fix validation sometimes modifying builtins.
When validating some shaders with out-of-bounds array indexes,
we would write the sanitized index into the global symbol table.
We would then overwrite a wrong value for the builtin. This
fixes the WebGL test extensions/webgl-draw-buffers-max-draw-buffers.
Also mark const on as many uses ConstantUnion as we can.
BUG=angleproject:993
src/compiler/translator/IntermNode.cpp
src/compiler/translator/IntermNode.h
src/compiler/translator/Intermediate.cpp
src/compiler/translator/Intermediate.h
src/compiler/translator/ParseContext.cpp
src/compiler/translator/parseConst.cpp
src/tests/compiler_tests/ShaderExtension_test.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 7:56
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 6ba6eadce47bb9e304e06ac7b8ed15f73ad4bca9
Code-Review 0 : Jamie Madill
Code-Review +1: Kenneth Russell
Code-Review +2: Zhenyao Mo
Verified 0 : Kenneth Russell, Zhenyao Mo
Verified +1: Jamie Madill
Commit Queue : Chumped
Change-Id : If8c95f6054d07291e7014be0d4e35766ba2e943b
Reviewed-at : https://chromium-review.googlesource.com/269131
Rename ConstantUnion to TConstantUnion.
This clarified that we're using the Pool allocator/deallocator for
this type.
BUG=angleproject:993
src/compiler/translator/ConstantUnion.h
src/compiler/translator/InitializeVariables.cpp
src/compiler/translator/IntermNode.cpp
src/compiler/translator/IntermNode.h
src/compiler/translator/Intermediate.cpp
src/compiler/translator/Intermediate.h
src/compiler/translator/OutputGLSLBase.cpp
src/compiler/translator/OutputGLSLBase.h
src/compiler/translator/OutputHLSL.cpp
src/compiler/translator/OutputHLSL.h
src/compiler/translator/ParseContext.cpp
src/compiler/translator/ScalarizeVecAndMatConstructorArgs.cpp
src/compiler/translator/SymbolTable.h
src/compiler/translator/UnfoldShortCircuitAST.cpp
src/compiler/translator/glslang.y
src/compiler/translator/glslang_tab.cpp
src/compiler/translator/intermOut.cpp
src/compiler/translator/parseConst.cpp
src/tests/compiler_tests/ConstantFolding_test.cpp
Original comment by bugdroid1@chromium.org
on 4 May 2015 at 7:56
Original comment by jmad...@chromium.org
on 6 May 2015 at 9:22
Original issue reported on code.google.com by
jmad...@chromium.org
on 1 May 2015 at 9:33