search

gxsshallot / react-native-full-image-picker

Support taking photo, video recording or selecting from photo library.
MIT License
83 stars 21 forks source link

Error: Can't resolve './images/arrow_right.png' #9

Closed namnm closed 5 years ago

namnm commented 5 years ago

In the src/images we have *3x.png files. Look like we need to rename them?

namnm commented 5 years ago

Also this error: Error: Can't resolve 'react-native/Libraries/Image/resolveAssetSource' (using webpack)

gxsshallot commented 5 years ago

@namnm Sorry that I don't use webpack... @3x image is for React Native only, so why do not you use node node_modules/react-native/local-cli/cli.js xxxxxxx to start local debug server or bundle?

namnm commented 5 years ago

Because beside native app, we also build a web version of it via webpack and react-native-web. I think I should fork your repo meantime.

gxsshallot commented 5 years ago

@namnm You can fork and change file name without @3x, since @3x is for iOS and Android only. Or change code such as Platform.OS === 'ios/android/web' to require different image. Thanks for using it~~~

gxsshallot commented 5 years ago

@namnm If you think your code is general style, you can give me a pr~

namnm commented 5 years ago

Ok I think we will use other library to handle file picker in web by Platform.OS. To fix webpack build error, we added new webpack.IgnorePlugin(/react-native-full-image-picker/, /.*/) to the plugins.