How is this module different from eslint-grunt, grunt-eslint?

[Nate-Wilkins]

This is more of an issue concerning why someone should use this module over one of the pre-existing modules. npm allows multiple modules that do the same thing but us users should be aware of the consequences and confusion these multiple modules bring.

So we should probably cover a few things

• How does this differ from eslint-grunt?
• How does this differ from grunt-eslint?
• What are the problems this module solves?
• And if so are they easily mergable to an existing module?
• And if not does a name similar to an existing module a good representation to what this module does?

Again I'm not really up to par with this module so bear with me :+1:

[gyandeeps]

@Nate-Wilkins I think I have explained what this plugin does on the PR sent to eslint.

[Nate-Wilkins]

I reread the documentation and compared it to grunt-eslint. I do see that there's a silent option that this plugin can specify that grunt-eslint hasn't implemented. Is the silent option the only feature this has vs grunt-eslint?

[gyandeeps]

It doesnt support different mixes of eslint. https://github.com/gyandeeps/grunt-contrib-eslint#example-with-custom-rules-for-node-and-browser-files

[Nate-Wilkins]

Mixes? Are you talking about targets?

[gyandeeps]

yes the targets.

[Nate-Wilkins]

I see. I'm pretty positive targets are a built in infrastructure to grunt thus any plugin for grunt should be able to have multiple targets.

[mgol]

The grunt-eslint plugin supports targets as it's a Grunt multitask and they support targets by default.

This plugin doesn't do anything grunt-eslint doesn't already do except specifying silent: true by default.

[gyandeeps]

@mzgol Please try this scenario https://github.com/gyandeeps/grunt-contrib-eslint#example-with-custom-rules-for-node-and-browser-files

Do let me know if it works out with grunt-eslint. Thanks

[mgol]

@gyandeeps I don't have time to recreate the whole structure to test now but just looking at the code is enough; your module does exactly the same what grunt-eslint does except silent handling; there're absolutely no other differences (except stylistic ones) in code of those tasks so they cannot behave differently.

[mgol]

Besides, for such a client-server structure it's better to declare one target & put separate .eslintrc files in server & client directories; in this way it will work seamlessly with editor integrations.

[gyandeeps]

try it out whenever you get time plz... I use this library for my own project and i am not forcing anyone to use this library. If you dont like this library then u can keep on using grunt-eslint. Thanks

[Nate-Wilkins]

I've looked at the 'scenario' that you've mentioned and don't understand it at all except that different targets can be specified? Which isn't different then existing plugins... Could you document it a little better especially since you think that's the only defining difference between these other plugins?

[mgol]

Well, grunt-eslint works fine with targets for me so if you want me to check why it doesn't work for you you'll need to provide me a whole example project on GitHub where your plugin works and grunt-eslint doesn't.

Everyone can write any software they want obviously but when you write a task almost the same as another one and advertise it in ESLint docs then it's natural to ask questions. Especially that you gave it a name that will mislead many people into thinking it's somehow more official than grunt-eslint.

I have an impression you misunderstood sth in the configuration of grunt-eslint and forked it (or wrote your own very similar task) instead of finding the real problem. And if there's a bug it's better to report it and send a pull request than to create your own, fragmenting a community.

On Saturday, July 12, 2014, Gyandeep Singh <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

try it out whenever you get time plz... I use this library for my own project and i am not forcing anyone to use this library. If you dont like this libraray then u can keep on using 'grunt-eslint'. Thanks

— Reply to this email directly or view it on GitHub https://github.com/gyandeeps/grunt-contrib-eslint/issues/1#issuecomment-48820989 .

Michał Gołębiowski