search

gyandeeps / gruntify-eslint

Grunt plugin for Eslint
MIT License
14 stars 8 forks source link

grunt-contrib-eslint doesn't work with eslint 1.0.0 #9

Closed klausbayrhammer closed 9 years ago

klausbayrhammer commented 9 years ago

eslint released v1.0.0 and made some breaking changes. When running the grunt-eslint-task with eslint v1.0.0 the following error occurs:

Warning: Cannot read property 'execute' of undefined Use --force to continue.
TypeError: Cannot read property 'execute' of undefined
    at Object.<anonymous> (/src/node_modules/grunt-contrib-eslint/tasks/eslint.js:21:26)
    at Object.<anonymous> (/src/node_modules/grunt/lib/grunt/task.js:264:15)
    at Object.thisTask.fn (/src/node_modules/grunt/lib/grunt/task.js:82:16)
    at Object.<anonymous> (/src/node_modules/grunt/lib/util/task.js:301:30)
    at Task.runTaskFn (/src/node_modules/grunt/lib/util/task.js:251:24)
    at Task.<anonymous> (/src/node_modules/grunt/lib/util/task.js:300:12)
    at /src/node_modules/grunt/lib/util/task.js:227:11
    at doNTCallback0 (node.js:408:9)
    at process._tickDomainCallback (node.js:378:13)
    at Function.Module.runMain (module.js:469:11)

Is grunt-contrib-eslint in the npm-registry still maintained or should we swtich to gruntify-eslint?

p-m-p commented 9 years ago

I forked this to patch it but looks like the work is already done https://github.com/gyandeeps/gruntify-eslint/compare/v0.1.1...master

Can we get it published? Thanks.

gyandeeps commented 9 years ago

@p-m-p @klausbayrhammer Guys sorry about that. I have the changes already merged. I will release in next 5 mins. Make sure if you use eslint 1.0.0, your dependency for gruntify-eslint is also 1.0.0.

gyandeeps commented 9 years ago

I have released 1.0.0 version. https://github.com/gyandeeps/gruntify-eslint/releases/tag/v1.0.0 Use this if you are using eslint 1.0 version.

gyandeeps commented 9 years ago

Please install using the name gruntify-eslint

p-m-p commented 9 years ago

No worries dude, thanks for the quick update!

Sent from my iPhone

On 3 Aug 2015, at 15:29, Gyandeep Singh notifications@github.com wrote:

@p-m-p @klausbayrhammer Guys sorry about that. I have the changes already merged. I will release in next 5 mins. Make sure if you use eslint 1.0.0, your dependency for gruntify-eslint is also 1.0.0.

— Reply to this email directly or view it on GitHub.