search

gyang9 / dunendggd

A tool for complicated detector geometry generation
1 stars 4 forks source link

Python version inconsistencies #21

Open quantatanu opened 4 years ago

quantatanu commented 4 years ago

Hi,

I was able to install duneggd and I am loving it, although initially I and some of us had some issues. The GeGeDe install instructions specifically advises to install gegede using python3, but duneggd is in python2, which fails when gegede-cli (python3) is run! But, a workaround is installing GeGeDe using python2 ignoring Brett's instructions. I was wondering if you could mention this in your install instructions as some of us had problems running duneggd.

Thanks

ebrianne commented 4 years ago

I want to backup this. I have already made a branch on my own repo where I changed things to be py3 compatible. See here. If this is deemed necessary, one can create a branch on this repo to have both python2 and python3 versions. But ultimately, things will have to move to python3 as python2 gets out of support soon.

quantatanu commented 4 years ago

I changed things to be py3

I tried your version, there are still prints that complain about missing ( ) around. I am trying after translating all print "struff" to print("stuff")

ebrianne commented 4 years ago

Did you checkout the correct branch? I guess you did not.

kordosky commented 4 years ago

I am quite happy to move on to python3 but I wonder if we should do a bit of consulting with users to let them know this is coming. We don't have too many:

Eldwan, on a side note, you should probably become a dev going forward.

On Fri, Jun 12, 2020 at 6:57 AM Eldwan Brianne notifications@github.com wrote:

Did you checkout the correct branch? I guess you did not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gyang9/dunendggd/issues/21#issuecomment-643209974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFVH4SA53P6BQJGDASKKXTRWICXXANCNFSM4NRELYGA .

-- Professor of Physics Small Hall 335B William & Mary makordosky@wm.edu Phone: +1 (757) 221 5522 FAX: +1 (757) 221 3540

quantatanu commented 4 years ago

Did you checkout the correct branch? I guess you did not.

Thanks! Indeed I did not! It works like a charm. Just a side question: I have just started learning this and was wondering where can I find docs on various dimensions. I see that the world is 300x300x300 m^3 box, but when I display the geometry using materialDisplay.C, I see a much larger (red KLOE circle is just 7m diameter) rectangular volume: image I don't see such a big dimension in any of the cfgs. ND CDR does not have such specific details of the surroundings.

Thanks

quantatanu commented 4 years ago

atanu (sorry, I don't know you)

I have joined DUNE a few weeks ago.

Bing Guo was/is working (or developed) on the STTs, I think.

ebrianne commented 4 years ago

I am quite happy to move on to python3 but I wonder if we should do a bit of consulting with users to let them know this is coming. We don't have too many: me eldwan guang atanu (sorry, I don't know you) Patrick Koller (and others working with him?) Matt Meuther and students working with him. * ... ? Eldwan, on a side note, you should probably become a dev going forward. … On Fri, Jun 12, 2020 at 6:57 AM Eldwan Brianne @.***> wrote: Did you checkout the correct branch? I guess you did not. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFVH4SA53P6BQJGDASKKXTRWICXXANCNFSM4NRELYGA . -- Professor of Physics Small Hall 335B William & Mary makordosky@wm.edu Phone: +1 (757) 221 5522 FAX: +1 (757) 221 3540

Indeed, I agree we need to see with the current users. I could point this during the next ND Software integration meetings. But could be merged already as a branch? I ll be happy to be a dev 👍 .

ebrianne commented 3 years ago

Inconsistencies fixed in PR #25. Issue can be closed.