search

gyf304 / vmcli

A set of utilities (vmcli + vmctl) for macOS Virtualization.framework
BSD 2-Clause "Simplified" License
826 stars 44 forks source link

Unable to start VM with networking #5

Closed SimonTate closed 3 years ago

SimonTate commented 3 years ago

Hi,

Firstly, thanks for this project. Extremely useful. 😄

I have noticed an issue, and found the root cause, but I'd like to discuss the direction of any PR.

The issue:

When running vmcli on main with the networking portion left in, the VM never starts and silently fails. If I remove the networking code, then vmcli starts the VM with no issues (except no networking, obviously).

Debugging this, found the following log in console: default 08:55:10.482714+0000 InternetSharing VMNet in NAT mode can't be started now due to an active InternetSharing session on en0.

The fix:

Disable InternetSharing. Simple as that. Then everything works as expected (with a NAT device, haven't tested bridge mode).

How should we "fix" this? A note in documentation? Or a check in the code for this scenario (if possible?)?

gyf304 commented 3 years ago

I added a print to stderr if the VM fails to start, hope that will make things easier to debug. Also added a note for InternetSharing in README.md. Thank you for your feedback!

SimonTate commented 3 years ago

Looks great. Thanks!