search

gyli / PyWaffle

🧇 Make Waffle Charts in Python.
MIT License
578 stars 105 forks source link

Font awesome license #19

Closed toddrme2178 closed 4 years ago

toddrme2178 commented 4 years ago

I notice that files from the Font Awesome project are being used. The project's license requires attribution. IANAL, and I am not affiliated with that project, but I think there probably needs to be a license file for these files, and this needs to be in the MANIFEST.in file (see #18) so it is included in sdists.

gyli commented 4 years ago

Nice catch.

Looks like having MANIFEST.in file is a better solution than specifying package_data in setup.py, since font files are missing in previous .tar.gz file.

I will merge the PR and exclude some docs and examples files, since that's only for ReadTheDocs.

However, to be clear, I don't see the current packing has any issue with Font Awesome license. Font Awesome does require attribution, while it also mentions the font files contain sufficient attribution. The License file of PyWaffle is also packed under dist-info folder.

gyli commented 4 years ago

https://github.com/gyli/PyWaffle/pull/18