search

gyli / PyWaffle

🧇 Make Waffle Charts in Python.
MIT License
578 stars 105 forks source link

Bump Font Awesome to v6 #27

Closed jennynz closed 2 years ago

jennynz commented 2 years ago

Hi there! Firstly, just wanted to say I absolutely love this package - it works so seamlessly, and you've really thought of everything in terms of how people might want to tweak things to make some beautiful visualisations!

I noticed that Font Awesome released v6 (in Feb 2022) which have quite a few new icons, so I thought I'd bump the version to their latest. Do let me know if it's not just a matter of bumping the version here!

gyli commented 2 years ago

Hi @jennynz, thank you for the PR!

PyWaffle contains a copy of Font Awesome otf files, and a mapping file (pywaffle/fontawesome_mapping.py generated by scripts/get_fontawesome.py, the file you updated), could you update them as well? Previous update should be helpful if you don't know where they are https://github.com/gyli/PyWaffle/pull/10.

gyli commented 2 years ago

@jennynz Never mind, I have finished the changes. It's merged and you will see it in next version soon!