Closed asongtoruin closed 5 years ago
Thank you for bringing this up. I will update FontAwesome version shortly.
Above is a PR based around 2i from the above suggestions. It seems to work fairly well though I haven't been able to check it extensively. Here's a chart based on one of the examples given for the module and the new icon set
Generated using:
fig = plt.figure(
FigureClass=Waffle,
rows=5,
values=data,
colors=("#232066", "#983D3D", "#DCB732"),
legend={'loc': 'upper left', 'bbox_to_anchor': (1, 1)},
icons=['democrat', 'republican', 'person-booth'], icon_size=12,
icon_legend=True
)
Hello,
Thanks for creating this module, it's really useful and pretty straightforward to use.
One thing I've noticed is that the module currently uses FontAwesome v4.7.0, with the latest version of FA being v5.5.0. It'd be nice to be able to use the latest set of icons and updating the equivalence should be relatively straightforward through the cheatsheet they provide, but the download is now (I believe since 5.0) split into three
.otf
files - "solid", "regular" and "brands". I see there being two ways to deal with this:icon_set
as a string).I am happy to work on a PR for this based on your preference. I think 2i would work best (and might start looking at implementing it), but will defer to your judgement. There may also be some compatibility issues with name changes, but I think it's worth it for the wider set of icons available.
Thanks,
Adam