Fix segfault on Ubuntu 20.04

gymreklab / GangSTR

A tool for profiling long STRs from short reads

GNU General Public License v2.0

85 stars 16 forks source link

Fix segfault on Ubuntu 20.04 #97

Closed jmarshall closed 3 years ago

jmarshall commented 3 years ago

With optimisation on, this Ubuntu version's compiler was miscompiling find_longest_stretch() such that it would always crash. Adding the missing return makes it optimise the function correctly. Fixes #92.

Similarly update trace_back() even though it appears to be currently unused.

You may want to consider investigating any other warnings produced while compiling GangSTR :smile:

nmmsv commented 3 years ago

This seems to fix the problem on my end as well. Thank you so much for your contribution. I'll merge and create a new release soon.