search

gymzatan / SMT1-iOS-to-GBA

Bring the officially localized SMT1 script from iOS to GBA
GNU General Public License v3.0
46 stars 4 forks source link

Better patching for windows #6

Open Ds886 opened 3 years ago

Ds886 commented 3 years ago

fixed the batch script for windows to work just like bash https://github.com/Ds886/SMT1-iOS-to-GBA

Ds886 commented 3 years ago

https://github.com/gymzatan/SMT1-iOS-to-GBA/pull/8

tested on vm should be working but would welcome external verfication

MediaMaquina commented 3 years ago

The new SMT1_create.bat doesn't work on windows 7. At least for me. I have previously patched this 3 times on older betas and never had an issue. But v1.0 batch doesn't work, just flashes and closes and doesn't do anything. If i open a prompt and run it manually it says this:

Untitled

As you can see everything is in place.

This command however works: copy /b SMT1_1_gba.gba+SMT1_2_ios.gba SMT1_new.gba

Ds886 commented 2 years ago

This happen because you didn't [provide parameters of the file making it that the syntax invalid as the IF was missing parameter. IF NOT EXIST ( instead of IF NOT EXIST gbarom.gba (

you need to provide parameters to the command SMT1_create <path to gba rom> <path to ios rom> I will try to create a fix that if no parameter passed it will break with more informative message

Ds886 commented 2 years ago

https://github.com/Ds886/SMT1-iOS-to-GBA/tree/fix-error-batch I don't have a testing set up currently but this should bail out if no parameters provide with more helpful error Working.

Ds886 commented 2 years ago

Would be happy if it can be tested by a windows 7 user, errors should be more on point.