gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
201 stars 25 forks source link

Feature Request: Routing downloads by clicking link or going to download url along instead of just from context menu #106

Open axbrev opened 5 years ago

axbrev commented 5 years ago

Would really like the ability to route downloads by simply clicking a link rather than using the context menu. There is not always a web interface/download link to click to get a context menu for and would find being able to route simply by going to a download link very helpful. I have scheduled tasks that run and go to urls but have no way to intelligently route them into folders.

Your addon is perfect for this but is limited by the context menu. Another addon Download Router does this but has no way to route based on specific urls.

Hopefully you can look into this as I think it would open up a whole new realm of possibilities.

gyng commented 5 years ago

There's a basic click-to-save (alt+click by default) in the options under "Keyboard Shortcuts" to save things.

Unfortunately Firefox cannot intercept downloads right now as downloads.onDeterminingFilename is not implemented. I'm considering implementing for Chrome in the back of my mind as Chrome does have it but with the impending Chrome webextension changes it's something I'd postpone until that actually happens.

vith commented 5 years ago

What impending Chrome webextension changes do you refer to?

https://bugzilla.mozilla.org/show_bug.cgi?id=1245652 is the upstream firefox bug for "Implement chrome.downloads.onDeterminingFilename" for anyone who wants to follow their progress.

gyng commented 5 years ago

@vith The changes I was referring to are the v3 manifest changes detailed in https://docs.google.com/document/d/1nPu6Wy4LWR66EFLeYInl3NzzhHzc-qnk4w4PX-0XMw8/

But taking a deeper look at the document it seems like there won't be any significant breakages (and I can't find more recent news on it), so I don't think this feature request is actually blocked by it. I'll probably take a look into this when I look at #109 as well.

Hopefully soon, since I've been quite strapped for time lately.

gyng commented 5 years ago

I've done some initial investigation for this. It's possible and will take some work to jury rig existing code.

Note to self: a rough sketch of a possible implementation:

KernelLeak commented 5 years ago

Would it at least be possible to make the "Click To Save" feature optionally do routing instead of saving to the default folder, much like "Exclusively use routing and rename rules" does for the context menu?

That would make that feature much more valuable.