search

gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
210 stars 26 forks source link

not saving images whose URLs have dynamic parameter suffixes #126

Open qlassiqa opened 4 years ago

qlassiqa commented 4 years ago

The extension doesn't save images whose URLs contain some dynamic parameters suffixed to the image filename. For example, URLs like cdnb.artstation.com/..../mei-mo-af-small.jpg?1530540305 will simply throw a 'Failed - Download Error' when trying to save, then it opens the Chrome save dialog to manually save it, making it an unfriendly and slow user experience.

Another bug is related to how Squarespace-based website images are saved, which have URLs like images.squarespace-cdn.com/..../Squarespace+Coffee+Shop+Website+Example?format=1500w - in this case, the extension saves the lowest resolution image instead of the one displayed at 1500px (I assume the extension just removes the parameter and thus saves the low resolution image instead of the one actually displayed to the user with that parameter, so you basically end up saving only low quality images instead of the ones shown to you)

Note: the above bugs happen in both Chrome & Firefox on Windows.

gyng commented 4 years ago

This shouldn't be happening as it used to save twitter images with params at the end. Needs investigation.

edjroot commented 4 years ago

FWIW, I just tested the extension (Chrome, Windows) with both URLs and it worked fine.