search

gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
204 stars 25 forks source link

Add support for multiple capture fields (#160) #181

Closed MaddyKakkoHeart closed 2 years ago

MaddyKakkoHeart commented 2 years ago

Implements #160

Multiple fields:

firefox_SC14PoncHG

Single field:

6xrrKt9RJj

As you can see, the matched URL is included in the results. I was not sure whether or not to remove this, as technically it was previously possible to retrieve this via $0 Also, perhaps this could use some tests. Please let me know and I will add them.

Linter and tests all passed.

Signed-off-by: Maddy <maddykakkoheart@protonmail.com

MaddyKakkoHeart commented 2 years ago

Thanks for the contribution! What a pleasant surprise 😄

This add-on is essential to my browsing experience, so allow me to thank you more!

Generally LGTM! I can add a small test for this after merging if you're too busy for it. I'll go ahead and merge/release at the end of the week if there's no other changes.

Ah, yeah, I don't think I have time to get to it...

Sorry you had to go through the code, I coincidentally happen to be adding types to this right now and it's not exactly pleasant...

Your code is very easy to read, no need to apologize 😄