gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
208 stars 26 forks source link

Unable to save to paths longer than 18 characters after update to version 3.7.0 #200

Closed gtsaf0 closed 1 year ago

gtsaf0 commented 1 year ago

Hello

This started to happen on the new version. The message that shows on Firefox console is: "browser.ui.interaction.content_context - The key length must be limited to 72 characters." Path I'm trying to write to is 22 characters long, 44 characters long with the filename and the file extension.

Thanks

gyng commented 1 year ago

I can't replicate this, do you have an example I can try?

gyng commented 1 year ago

I've released 3.7.1 with some refactors to menu creation. I can't really tell if that fixes this issue (hopefully without creating new bugs).

gtsaf0 commented 1 year ago

I've released 3.7.1 with some refactors to menu creation. I can't really tell if that fixes this issue (hopefully without creating new bugs).

This seems to have fixed it, many thanks.

gtsaf0 commented 1 year ago

I can't replicate this, do you have an example I can try? Here is a snippet of my menu .

pics pics/cat // (alias: cat) pics\cat // (alias: general) pics\cat\white // (alias: white)

The default path is on a drive different than the default Windows path, so D:\Downloads If it is related, the target of the symlink has a space and a '&' in its path.

seth-rah commented 1 year ago

Having issues saving here on Chrome as well since updating to 3.7.0

No errors being collected on Chrome, but I can only save to default folder. Any saves to the folders through a symlink just result in no function being performed (at least visually)

gyng commented 1 year ago

~Hey, I tried with more test cases and a symlink and I still can't replicate on Windows/FF111.0a1 or Chromium/112.0.5581.0 Canary.~

~Some extra debugging that might help me:~

~In a dev profile or otherwise (backup your settings first!), try these extensions and see if they are broken. They are builds between 3.6.0 and 3.7.0.~

~about:addons > Gear icon > Install Add-on From File~

~- https://github.com/gyng/save-in/releases/download/v3.6.0/save_in_-3.6.0.zip~ ~- savein-9a3aa2e4e337f917ed3e327f6659871db33b8d86.zip~ ~- savein-35b32d59921f5884698aecc272d2acf4198a4130.zip~ ~- savein-3aa3c98e207adb714271db3a17d3616a0935a6ec.zip~

3.7.1 Might have fixed it?

gyng commented 1 year ago

@seth-rah I've updated Chrome to 3.7.1, pending approval. Here's hoping it fixes the issue. If I can't replicate the issue I will rollback published versions to 3.6.0, if possible.

seth-rah commented 1 year ago

Thanks

I'll have a look tomorrow to see if the problem is solved

seth-rah commented 1 year ago

Can confirm that updating to 3.7.1 has resolved the issue