search

gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
208 stars 26 forks source link

Firefox detected as chrome #214

Closed nico202 closed 6 months ago

nico202 commented 8 months ago

I'm using firefox 123.0.1 on ubuntu (snap). The settings appear like this: image options with "firefox" are disabled, options with "Chrome" label are enabled.

I see that the chrome detector script checks for typeof browser https://github.com/gyng/save-in/blob/8960e020772137d8399876e0740395cd2e166ff0/src/chrome-detector.js#L28 which on the console returns "undefined" image

gyng commented 6 months ago

Thanks for the report. 3.73 has been submitted to the Firefox AMO which should fix this. The options page was disabling controls before before browser detection was completed.

nico202 commented 6 months ago

Thanks! Closing as it seems to be fixed :) Now my main problem is #212