search

gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
201 stars 25 forks source link

adding Dutch locale messages #72

Closed 80486dx closed 5 years ago

80486dx commented 6 years ago

Would it be possible to include the Dutch language (nl) for the messages. _locales.zip

gyng commented 6 years ago

Thanks for the contribution! I can't speak Dutch, and I'm not sure how I feel about incomplete localisations but I'll go ahead and add this in for the next release.

There is some text in the menus that I forgot to hook up to the locales file so the coverage will not be 100%. It is something I'll fix when I add your translations. If new labels are added they won't be translated.

The options page is also totally separated from the extension's background script, and I will have to hook it up to the locales file.

80486dx commented 6 years ago

I'm with you, incomplete localisations is bad. I am a native Dutch speaker. I'll add the missing translations as soon as the hooks are found.

gyng commented 6 years ago

@80486dx I've dumped a whole bunch of localisation hooks in 2.7.0, but please don't feel pressured to fill those out. I've also included (but left disabled) the nl localisation file you included in the first post in the extension. Thanks for your contribution!

80486dx commented 6 years ago

_locales.zip Thanks a lot for including the nl locatisation file. I have filled out the Dutch localisation hooks for 2.7.0.

PS As a workaround for not writing outside the Firefox download-folder, I have set the Firefox default Download dir to the root of the user home directory.

gyng commented 5 years ago

I've had trouble testing it in Firefox because my local setup isn't configured for nl, but it seems to work in Chrome. Since it seems to cover most places I've gone ahead enabled this in 3.1.0.