gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
201 stars 25 forks source link

Chrome settings not saving. #76

Closed ZzzZombi closed 6 years ago

ZzzZombi commented 6 years ago

No problem on Firefox Nightly. Using Chrome Dev, none of the settings are saved upon quitting the settings page.

Is there a "Save" button that I'm missing? On Firefox it just saves as you change parameters.

gyng commented 6 years ago

I'll investigate this. It seems to be saving on my Chrome 67 stable, which version are you on? The settings are supposed to save as they are changed. You can try restoring defaults and seeing if that helps.

DanaMW commented 6 years ago

Thank you for the Update friend (just putting it here for you see it)

gyng commented 6 years ago

@DanaMW thanks for the support. Are you encountering this issue as well? If so, can you share your Chrome version?

DanaMW commented 6 years ago

Your more than welcome. I use this programs many many times a day every day lol. And yes as I told you a While back my chrome (Version 69.0.3486.0 (Official Build) dev (64-bit)) has been doing it. I just read in an export on use for now. Some versions even that didn't work as it would depart as fast as the page as I left it.

DanaMW commented 6 years ago

I use a fair amount of scripts and style files in Tamper and Stylus (Another great program) so I will do a complete clean out and conflict test this morning for us.

gyng commented 6 years ago

I still can't replicate any issue in Windows Version 69.0.3486.0 (Official Build) dev (64-bit).

This is on a fresh install of both the extension and Chrome Dev. I'll try it on another OS once I get access to it.

It'll be great if anyone is able to post any error logs (extension details > inspect background page and the Errors in the top level). I'm wondering if this is caused by bad settings or the like.

Examples of config files (if not sensitive) will be helpful too (Other Settings > Export).

ZzzZombi commented 6 years ago

Sorry for taking so long to reply.

Issue seems to be solved for now and been working for a few days now, no problem.

I'm using Chrome Dev Version 69.0.3486.

I don't know how exactly it started saving the settings but all I did was selecting and deselecting some setting parameters' checkboxes (so it shows that green confirmation icon). That's it.

Other wild guess of mine, could it be a windows permission problem? For example Chrome.exe not having privileges to write to the extension's config file.

Oh and here are the collected errors from the extension page:

Unrecognized manifest key 'applications'.
{
   "applications": {
      "gecko": {
         "id": "{72d92df5-2aa0-4b06-b807-aa21767545cd}"
      }
   },
Unrecognized manifest key 'developer'.
   "developer": {
      "name": "Ng Guoyou",
      "url": "https://github.com/gyng/save-in"
   },
found unexpected key 'browser_style'
{
   "applications": {
      "gecko": {
         "id": "{72d92df5-2aa0-4b06-b807-aa21767545cd}"
      }
   },
Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.
{
   "applications": {
      "gecko": {
         "id": "{72d92df5-2aa0-4b06-b807-aa21767545cd}"
      }
   },

And here's my config:

{
  "conflictAction": "uniquify",
  "contentClickToSave": true,
  "contentClickToSaveButton": "MIDDLE_CLICK",
  "contentClickToSaveCombo": "17",
  "debug": false,
  "enableLastLocation": true,
  "enableNumberedItems": false,
  "fetchViaContent": false,
  "filenamePatterns": "",
  "keyLastUsed": "a",
  "keyRoot": "a",
  "links": false,
  "notifyDuration": "1000",
  "notifyOnFailure": true,
  "notifyOnRuleMatch": true,
  "notifyOnSuccess": true,
  "page": false,
  "paths": "************",
  "preferLinks": false,
  "prompt": false,
  "promptIfNoExtension": false,
  "promptOnFailure": false,
  "promptOnShift": false,
  "replacementChar": "_",
  "routeExclusive": false,
  "routeFailurePrompt": false,
  "selection": false,
  "shortcutLink": false,
  "shortcutMedia": false,
  "shortcutPage": false,
  "shortcutTab": false,
  "shortcutType": "HTML_REDIRECT",
  "tabEnabled": false,
  "truncateLength": "240"
}
gyng commented 6 years ago

@ZzzZombi thanks for the logs and the update, and do feel free to report if you notice anything wrong again. Sometimes the new versions have breaking changes that need fixing before they hit stable. Since I don't use Nightly/Canary as my daily drivers I don't have advance warning of when things will break.

I don't know what exactly happened in this case, but it'll be annoying if it keeps happening.

ZzzZombi commented 6 years ago

@gyng No problem. I guess let's just say it's one of those "very rare, weird, only applies to a specific case" kind of bug. I'll make sure to report any future problems. And thanks for this essential extension.

DanaMW commented 6 years ago

Uncaught (in promise) TypeError: Illegal invocation: Function must be called on an object of type StorageArea at resolve (chrome-polyfill.js:11) at new Promise () at Object._promisify [as get] (chrome-polyfill.js:10) at Object.OptionsManagement.loadOptions (option.js:128) at window.init (index.js:11) at index.js:322

DanaMW commented 6 years ago

still not saving ... that was in your Ext background page

gyng commented 6 years ago

Thanks for the error. That looks like a problem with my own polyfill. I've been waiting for mozilla/webextension-polyfill to release 0.3.0 (which they just did!), so I'll see if I can get that integrated instead.

DanaMW commented 6 years ago

Very cool. That was the latest Chrome Dev Google Chrome is up to date Version 69.0.3493.3 (Official Build) dev (64-bit Thanks again for sticking with us :)

gyng commented 6 years ago

I've published 2.7.2 for Chrome which uses Mozilla's polyfill. I can't replicate the issue locally so I can't tell if this will fix your issue, so please take a look.

DanaMW commented 6 years ago

I loaded it and the setting were all in there set correct;y and visible, That fixed it thank you.

gyng commented 6 years ago

Marking this as resolved. Thanks to all for the bug reports.