search

gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
201 stars 25 forks source link

v2.7.3 seems to have broken the rename downloads feature #80

Closed FatOrangutan closed 5 years ago

FatOrangutan commented 5 years ago

STR:

  1. Add the following rule: 
    filename: (.*)(:|-|=)(large|small|medium|thumb|orig)
sourceurl: pbs.twimg.com
capture: filename
into: :$1:
  2. Go to https://pbs.twimg.com/media/Di6uEBuVsAEYVBw.jpg:orig
  3. Right click > Save In...

ER / AR with 2.7.1: download is renamed to Di6uEBuVsAEYVBw.jpg. Screesnhot: 2 7 1

AR with 2.7.3: Save As download window shows up with prepopulated name as Di6uEBuVsAEYVBw.jpg_orig. Screenshot: 2 7 3

gyng commented 5 years ago

I need better tests, there's been too many breakages recently. For now I've disabled 2.7.3 for Firefox. For Chrome I'll work on getting a hotfix out by the end of the day.

gyng commented 5 years ago

Released 3.0.0 with a fix for this. I've done some testing on Chrome and Firefox, so it should be OK.

gyng commented 5 years ago

I'm assuming this is fixed, please reopen if that's not the case.