search

gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
210 stars 26 forks source link

[Request] Vivaldi Support #86

Open Fainec opened 6 years ago

Fainec commented 6 years ago

Hello,

All extensions on Vivaldi come from the Chrome Webstore. However, this extension does not work at all, the downloaded image get directly in the default download folder. Can you maybe do the compatibility with the Vivaldi Browser ?

gyng commented 6 years ago

Browsers (=Chrome/Firefox) only allow downloads via the web extension API into the default downloads directory. If you want to save it outside, you will need a symlink inside the default download directory.

If saving into relative directories (eg subdir/foo/bar) saves it into the root (default downloads directory), then it's broken.

Vivaldi is not something I'm planning on supporting because it's too much work. I don't know if the extension is really broken on Vivaldi, but I'm open to PRs if it's an easy fix.

Hadden89 commented 4 years ago

I actually think the extension works on Vivaldi. It saves on default directory/subdirectory as expected (without symlinks). The only issue I notice is the missing extension button.

//EDIT: I see the button in current Vivaldi 3.1.1929.28 / 83.0.4103.98

SenpaiSharp commented 4 years ago

It almost works to an extent. It follows all the proper renaming conventions and it finds the correct folder but it always opens up the save dialog, rather than just saving, regardless of what you do or what options to take.

I don't know enough about this language or web extension debugging to really understand the problem or how to gather good information for it. Under errors I get this

wrappedSendMessageCallback | @ | browser-polyfill.js:1117

and there's a message

Returning a Promise is the preferred way to send a reply from an onMessage/onMessageExternal listener, as the sendResponse will be removed from the specs (See https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/runtime/onMessage) Error at wrappedSendResponse (chrome-extension://meeadojfpdofefnhnkjkdgnlcchohfic/src/vendor/browser-polyfill.js:1043:65) at chrome-extension://meeadojfpdofefnhnkjkdgnlcchohfic/src/messaging.js:120:7 at onMessage chrome-extension://meeadojfpdofefnhnkjkdgnlcchohfic/src/vendor/browser-polyfill.js:1053:22)

Which seems erroneous in regards to a Chrome based browser?

I wish I had a better handle on the Devtools, because this feels like it's 90% there (conjecture, admittedly).