search

gyng / save-in

WebExtension for saving media, links, or selections into user-defined directories
MIT License
201 stars 25 forks source link

Problem with using Save in with RSS (podcasts) in Feedbro because files are not displayed as MP3 file #92

Open Wombat2018 opened 5 years ago

Wombat2018 commented 5 years ago

First of all, the extension is absolutely great. I have very little knowledge about coding, so excuse me for my question, if it should be stupid.

My problem is that some of my podcasts have not an MP3 extension in Feedbro, so Save in can not match my MP3 rule and the automatic download does not start. The MP3 extension appears only when I do a right klick and choose save target as. It is very strange because when I open the Feed in Firefox, there is an MP3 extension. Other podcasts do not have this problem because they are displayed as MP3 directly in Feedbro and the rule in Save in works.

Below there are screenshots to show my problem and the links for the feeds. The first two do not work, the third one does: wrong: https://audioboom.com/channels/4921650.rss wrong2: https://kurzpass.podigee.io/feed/mp3 right: https://www.theguardian.com/football/series/footballweekly/podcast.xml

wrong wrong2 right

Wombat2018 commented 5 years ago

I have solved my problem partially. I have changed my rule:

Old: fileext: mp3 into: symlink/:filename:

New: filename: into: symlink/:filename:

Nevertheless, there is a problem with audioboom. The nativefilename is applied instead of the filename.

fehl

gyng commented 5 years ago

Thanks for the report. I'm a bit busy at the moment but I'll take a look when I can.

Wombat2018 commented 5 years ago

Thank you! Meanwhile I checked all of my podcasts and here are some feeds with the same problem. For those feeds the nativefilename is applied instead of the filename

http://podcasts.files.bbci.co.uk/p02nrsln.rss https://audioboom.com/channels/4810176.rss http://feeds.soundcloud.com/users/soundcloud:users:213461595/sounds.rss http://feeds.soundcloud.com/users/soundcloud:users:167808304/sounds.rss https://audioboom.com/channels/4947077.rss

For the following, the problem is that the correct filename, which appears when you use right click and save target as in the browser, does not appear at all in the Save In file description (neither in the filename nor in the nativefilename), so the correct filename can not be applied:

http://rss.acast.com/atthematch https://rss.acast.com/onthecontinent https://audioboom.com/channels/4938942.rss https://audioboom.com/channels/4921650.rss

fe1 fe2

gyng commented 5 years ago

I did a quick look, but it's hard to diagnose because the RSS reader is gone in FF64. My best guess is: in the first case, the extension is not able to get the suggested filename from the Content-Disposition header. This is done using a separate request which might be blocked by the server. The Content-Disposition header can contain a download name hint for applications to use.

This is why Firefox can still get the actual filename when right-clicked and saved-as. Chrome should not have this problem because the extension uses the onDeterminingFilename API which gives a suggested filename to the extension without having to fire off another request.

In the second case, save-in's renaming features are not advanced enough to use page selectors, so it's quite impossible to extract filenames from the currently available variables. It's something I'd like to add, but will require a bunch of work.

Unfortunately this is something I don't think I can fix right now.

Are you using Firefox's built-in RSS reader? Firefox has removed that in FF64, so you will need to look for an extension or application to view feeds.