gyorilab / indra_network_search

REST API for querying the network of biochemical mechanisms in the INDRA DB.
BSD 2-Clause "Simplified" License
0 stars 2 forks source link

Release of new rest API with frontend #11

Closed kkaris closed 3 years ago

kkaris commented 3 years ago

This PR finalizes the release of the new INDRA Network Search utilizing FastAPI for the backend and Vue.js for the frontend.

Main differences from previous service:

Structure of Repository

The modules are structured around the following components:

Vue.js Frontend

The frontend is built with Vue.js providing a better structure and easier development than raw JavaScript + HTML. One benefit over using Flask + Jinja templates is the complete independence from the service running the FastAPI server, making it possible to have less downtime and quick patching. The frontend is available in indra_network_search/frontend.

cthoyt commented 3 years ago

How do you guys feel about applying black/isort since this is basically a full re-write? would make it easier to keep a consistent style

cthoyt commented 3 years ago

:shipit:

kkaris commented 3 years ago

Just discovered that I messed up something in the latest docs build off of dev/master, basically nothing shows up: https://indra-network-search.readthedocs.io/en/latest/modules/query.html

Compare to the build from package a month ago: https://indra-network-search.readthedocs.io/en/package/modules/query.html

I'll have to figure that out before merging.

cthoyt commented 3 years ago

Error in doc build:

...
 File "/Users/cthoyt/dev/indra_network_search/indra_network_search/data_models/__init__.py", line 112, in <module>
    class FilterOptions(BaseModel):
  File "/Users/cthoyt/dev/indra_network_search/indra_network_search/data_models/__init__.py", line 115, in FilterOptions
    stmt_filter: List[constr(to_lower=True)] = []
  File "pydantic/types.py", line 246, in pydantic.types.constr
TypeError: constr() got an unexpected keyword argument 'to_lower'
kkaris commented 3 years ago

Error in doc build:

...
 File "/Users/cthoyt/dev/indra_network_search/indra_network_search/data_models/__init__.py", line 112, in <module>
    class FilterOptions(BaseModel):
  File "/Users/cthoyt/dev/indra_network_search/indra_network_search/data_models/__init__.py", line 115, in FilterOptions
    stmt_filter: List[constr(to_lower=True)] = []
  File "pydantic/types.py", line 246, in pydantic.types.constr
TypeError: constr() got an unexpected keyword argument 'to_lower'

That seems very odd, the current version of pydantic has that keyword argument: https://pydantic-docs.helpmanual.io/usage/types/#arguments-to-constr

kkaris commented 3 years ago

~Will hold off on merge until tox test, docs build and build branch is merged: #19~ Skipping #19