search

gyorilab / mira

MIRA modeling framework
BSD 2-Clause "Simplified" License
9 stars 7 forks source link

Need a round-trip path for AskeNet <-> Mira #169

Closed djinnome closed 1 year ago

djinnome commented 1 year ago

Hi folks,

AskeNet models make it easy to generate the AskeNet serialization from a Mira model, but not easy to generate a Mira model from an AskeNet model. PR https://github.com/indralab/mira/pull/168 and PR https://github.com/indralab/mira/pull/167 complete the round trip for Regnets and Petrinets, respectively

bgyori commented 1 year ago

The goal is, actually, to be able to do roundtrips to/from the shared representation. For instance, mira.sources.askenet.petrinet can be used to read in a shared model (i.e., generate a Mira model from an AskeNet model). Did you run into an issue with that? It might just be a specific limitation in how that's implemented rather than a conceptual issue.

bgyori commented 1 year ago

Given the additional functions in #170 can this issue and the two PRs be closed? Or should I add anything else?

djinnome commented 1 year ago

No, this is all good. Let me know when you have merged #170 into main.

bgyori commented 1 year ago

I actually merged #170 yesterday so all those are now available on the main branch.