search

gyrocode / jquery-datatables-checkboxes

Checkboxes is an extension for the jQuery DataTables library that provides universal solution for working with checkboxes in a table.
https://www.gyrocode.com/projects/jquery-datatables-checkboxes/
MIT License
150 stars 61 forks source link

Use rowId for unique value of checkbox column #114

Closed d42ohpaz closed 2 years ago

d42ohpaz commented 4 years ago

From @nikitul

I made some bug fixes and some improvements including some of this request. Source: here. I supposed that if rowId is provided, it should be used. If not, is used cell.data(). I didn't used internal row number because that it could be changed using RowReorder or by adding new rows... and is a lot of extra work that could be avoided using a rowId.

Fixes #112

mpryvkin commented 4 years ago

Thank you for your contribution, @nikitul and @9ae8sdf76! Please allow me some some time to review the code.

I am not a fan of single commits that include lots of changes in multiple places. I also disagree with some suggested changes, for example, making the checkbox column searchable.